Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple streams #17

Merged
merged 1 commit into from
Jul 25, 2020
Merged

Add support for multiple streams #17

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions lib/alpaca/stream.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ defmodule Alpaca.Stream do
A simple client implementation would be:
```
defmodule AlpacaStreamClient do
use Alpaca.Stream
use Alpaca.Stream, url: "https://paper-api.alpaca.markets/stream"

def start_link() do
start_link(["account_updates", "trade_updates"])
Expand All @@ -18,6 +18,10 @@ defmodule Alpaca.Stream do
end
end
```

The `url` keyword is optional and if omitted will be defaulted to `"#{Client.api_host()}/stream"`
to key backwards compatibility.

## Supervision
Alpaca.Stream uses WebSockex under the hood

Expand All @@ -41,7 +45,7 @@ defmodule Alpaca.Stream do
### Example
```
defmodule TestStream do
use Alpaca.Stream
use Alpaca.Stream, url: "wss://data.alpaca.markets/stream"

@impl Alpaca.Stream
def handle_msg(msg, state) do
Expand All @@ -58,7 +62,9 @@ defmodule Alpaca.Stream do
| {:close, WebSockex.close_frame(), new_state}
when new_state: term

defmacro __using__([]) do
defmacro __using__(opts \\ []) do
url = Keyword.get(opts, :url, "#{Alpaca.Client.api_host()}/stream")

quote do
use WebSockex

Expand Down Expand Up @@ -88,7 +94,7 @@ defmodule Alpaca.Stream do
```
"""
def start_link(streams) do
{:ok, pid} = WebSockex.start_link("#{Client.api_host()}/stream", __MODULE__, :no_state)
{:ok, pid} = WebSockex.start_link(unquote(url), __MODULE__, :no_state)
authenticate(pid)

unless streams == [] do
Expand Down