Do not parse as JSON when window has a truthy 'json' prop #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FagnerMartinsBrack
force-pushed
the
fix-window-json
branch
6 times, most recently
from
7be0462
to
f35d99d
Compare
FagnerMartinsBrack
force-pushed
the
fix-window-json
branch
from
f35d99d
to
244367e
Compare
IE 6-8 throws an exception when trying to delete properties from window
FagnerMartinsBrack
force-pushed
the
fix-window-json
branch
from
244367e
to
46799da
Compare
| @@ -127,7 +127,7 @@ | |||
|
|
|||
| api.set = api; | |||
| api.get = function (key) { | |||
| return api(key); | |||
| return api.call(api, key); | |||
There was a problem hiding this comment.
Why do you pass "api" to this, if in "this" it expects window
There was a problem hiding this comment.
It does not expects window. See #251 (comment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #238.