Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

color.js.org #2760

Merged
merged 4 commits into from
Jan 30, 2019
Merged

color.js.org #2760

merged 4 commits into from
Jan 30, 2019

Conversation

akash-joshi
Copy link
Contributor

@MattIPv4
Copy link
Member

@akash-joshi Would you not want it to point to akash-joshi.github.io/neural-color-picker?
It appears that redirects to the .pw domain which suggests to me that your GitHub pages is configured to work with that and not the js.org subdomain that you have requested?

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account project This PR has a target of a project on an organisation or user account awaiting response This PR is waiting for a response from the requester labels Jan 30, 2019
@MattIPv4 MattIPv4 changed the title Neural Color Picker color.js.org Jan 30, 2019
@akash-joshi
Copy link
Contributor Author

@MattIPv4 I have set the gh-pages branch as source now. I have added the CNAME to that one. If there are any more issues, let me know

@MattIPv4
Copy link
Member

@akash-joshi your commit is here is still pointing to the pw domain and not your github pages directly?

@akash-joshi
Copy link
Contributor Author

@MattIPv4 Apologies, fixed

MattIPv4
MattIPv4 approved these changes Jan 30, 2019
View reviewed changes
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Commit valid, CNAME present, site appears to have content *

* based off https://github.com/akash-joshi/neural-color-picker/tree/gh-pages

@MattIPv4 MattIPv4 removed the awaiting response This PR is waiting for a response from the requester label Jan 30, 2019
@indus
Copy link
Member

indus commented Jan 30, 2019

Welcome https://color.js.org

@indus indus merged commit 5ff8534 into js-org:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattIPv4 MattIPv4 MattIPv4 approved these changes

Assignees
No one assigned
Labels
add This PR/issue is regarding adding a new subdomain project This PR has a target of a project on an organisation or user account user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akash-joshi @MattIPv4 @indus