Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aditya.js.org #3208

Merged
merged 2 commits into from
Jul 13, 2019
Merged

aditya.js.org #3208

merged 2 commits into from
Jul 13, 2019

Conversation

aditya81070
Copy link
Contributor

@aditya81070 aditya81070 commented Jul 13, 2019

I have requested for this domain in a previous pull request. The pull request was closed because of No Content tag. But, I found that the domain name has already been registered and entry for aditya.js.org was not added to cnames_active.js, that's why I am creating this pull request again.

@aditya81070 aditya81070 changed the title add entry to active aditya.js.org domain aditya.js.org Jul 13, 2019
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

Before we can accept your js.org domain request, your site must have reasonable content. ❌
Based on https://github.com/aditya81070/aditya81070.github.io/tree/master your site currently does not contain what we would consider to be reasonable content to grant a request.

Please see the wiki article: https://github.com/js-org/js.org/wiki/No-Content 📖

@MattIPv4
Copy link
Member

cc @indus looks like you forgot to drop this from the DNS zone?

@MattIPv4 MattIPv4 added add This PR/issue is regarding adding a new subdomain no content This PR has a target that contains no valid content for a request user This PR/issue is regarding a target on a GitHub user account labels Jul 13, 2019
@aditya81070
Copy link
Contributor Author

@matt I think, my website has the content. If I compare to the given example then It has content. I will deploy my portfolio on the same.

@aditya81070
Copy link
Contributor Author

@matt If you are only looking at index.html file then there will be no content as it is a Jekyll based static website and Github build this before hosting.
If you really want to see the content, go to https://aditya81070.github.io

@MattIPv4
Copy link
Member

@aditya81070 Yes I have checked your full site and I do not believe that a single post with the following content constitutes reasonable content. I believe this is essentially still just a name grab still.

Hey, Nice to see you here
Jul 13, 2019

You will see my blogs here. Don’t worry, it will be fun.

@aditya81070
Copy link
Contributor Author

@matt, I have updated the content. Take a look now.

@indus indus removed the no content This PR has a target that contains no valid content for a request label Jul 13, 2019
@indus
Copy link
Member

indus commented Jul 13, 2019

@MattIPv4 yes I missed to remove it.
Welcome https://aditya.js.org

@indus indus merged commit b50b3bf into js-org:master Jul 13, 2019
@aditya81070
Copy link
Contributor Author

aditya81070 commented Jul 13, 2019

@indus Thanks a lot. If you need any help or any project for the frontend, you can ping me. I am a react developer and do freelancing. Open for open source projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add This PR/issue is regarding adding a new subdomain user This PR/issue is regarding a target on a GitHub user account
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants