Reporter: TapReporter align actual with expected. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When comparing two strings, it is significantly easier to spot the difference when they are aligned. This change pads the label for `actual` with a couple of spaces so that the actual value is printed at the same indentation as the expected value. Previously the expected value was right shifted by 2 characters...
|
Thoughts? |
|
This certainly looks like an improvement! |
Krinkle
approved these changes
Aug 5, 2020
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Sep 8, 2020
Relevant changes: * Reporter: Align `actual` with `expected` in TapReporter. (Robert Jackson) js-reporters/js-reporters#107
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Sep 8, 2020
Relevant changes: * Reporter: Align `actual` with `expected` in TapReporter. (Robert Jackson) js-reporters/js-reporters#107
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Sep 10, 2020
Relevant changes: * Reporter: Align `actual` with `expected` in TapReporter. (Robert Jackson) js-reporters/js-reporters#107
Krinkle
added a commit
to qunitjs/qunit
that referenced
this pull request
Sep 10, 2020
Relevant changes: * Reporter: Align `actual` with `expected` in TapReporter. (Robert Jackson) js-reporters/js-reporters#107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When comparing two strings, it is significantly easier to spot the difference when they are aligned. This change pads the label for
actualwith a couple of spaces so that the actual value is printed at the same indentation as the expected value. Previously the expected value was right shifted by 2 characters...Before:
After: