Skip to content

Commit

Permalink
refactor(components/collapse): 把 CollapseGroup 的 options 属性重命名为 colla…
Browse files Browse the repository at this point in the history
…pseProps
  • Loading branch information
mengxinssfd committed Aug 1, 2023
1 parent cf95bb1 commit 3a50ba3
Show file tree
Hide file tree
Showing 9 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions packages/components/src/collapse/CollapseGroup.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { Collapse } from './Collapse';
const rootName = getComponentClass('collapse-group');

export const CollapseGroup: React.FC<CollapseGroupProps> = (props) => {
const { options, onChange, accordion, items, className, ...rest } =
const { collapseProps, onChange, accordion, items, className, ...rest } =
props as RequiredPart<CollapseGroupProps, keyof typeof defaultProps>;

const list = useRef(items);
Expand All @@ -32,7 +32,7 @@ export const CollapseGroup: React.FC<CollapseGroupProps> = (props) => {
return (
<div {...rest} className={getClassNames(rootName, className)}>
{list.current.map(({ onChange, ...rest }, i) => {
const opts = { ...options, ...rest };
const opts = { ...collapseProps, ...rest };
return (
<Collapse
{...opts}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/collapse/collapse.types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export type CollapseGroupProps = Omit<
React.HTMLAttributes<HTMLElement>,
'title' | 'children' | 'onChange'
> & {
options?: Partial<CollapseProps>;
collapseProps?: Partial<CollapseProps>;
accordion?: boolean;
items: CollapseGroupItem[];
onChange?: (item: CollapseGroupItem, index: number, active: boolean) => void;
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/collapse/demo/basic.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ const items: CollapseGroupItem[] = [
},
];
const App: React.FC = () => {
return <CollapseGroup options={{ expanded: true }} items={items} />;
return <CollapseGroup collapseProps={{ expanded: true }} items={items} />;
};

export default App;
2 changes: 1 addition & 1 deletion packages/components/src/collapse/demo/expanded.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ const items: CollapseGroupItem[] = [
const App: React.FC = () => {
return (
<div>
<CollapseGroup options={{ expanded: true }} items={items} />
<CollapseGroup collapseProps={{ expanded: true }} items={items} />
</div>
);
};
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/collapse/demo/extra.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ const App: React.FC = () => {
return (
<div>
<CollapseGroup
options={{
collapseProps={{
extra: '《道德经》',
}}
items={items}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/collapse/demo/icon-placement.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ const App: React.FC = () => {
return (
<div>
<CollapseGroup
options={{
collapseProps={{
iconPlacement: 'end',
extra: '《道德经》',
}}
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/collapse/demo/icon.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ const App: React.FC = () => {
return (
<div>
<CollapseGroup
options={{
collapseProps={{
icon: (active) => (
<Icon
className={`t-collapse__icon ${
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/collapse/demo/nest.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const items: CollapseGroupItem[] = [
title: '第二十三至二十五章',
extra: '嵌套',
expanded: true,
children: <CollapseGroup options={{ expanded: true }} items={nest} />,
children: <CollapseGroup collapseProps={{ expanded: true }} items={nest} />,
},
];
const App: React.FC = () => {
Expand Down
12 changes: 6 additions & 6 deletions packages/components/src/collapse/index.zh-CN.md
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@ export type CollapseGroupItem = CollapseProps & {
};
```

| 属性 | 说明 | 类型 | 默认值 | 版本 |
| --------- | ----------------------------- | ----------------------------------------------------------------- | ------ | ---- |
| accordion | 手风琴效果 | boolean | false | -- |
| items | 面板 item 数组 | CollapseGroupItem[] | -- | -- |
| options | items 的公共选项 | Partial\<CollapseProps> | -- | -- |
| onChange | 内部面板展开/收起时触发的回调 | (item: CollapseGroupItem, index: number, active: boolean) => void | -- | -- |
| 属性 | 说明 | 类型 | 默认值 | 版本 |
| ------------- | ----------------------------- | ----------------------------------------------------------------- | ------ | ---- |
| accordion | 手风琴效果 | boolean | false | -- |
| items | 面板 item 数组 | CollapseGroupItem[] | -- | -- |
| collapseProps | items 的公共选项 | Partial\<CollapseProps> | -- | -- |
| onChange | 内部面板展开/收起时触发的回调 | (item: CollapseGroupItem, index: number, active: boolean) => void | -- | -- |

其他说明。

0 comments on commit 3a50ba3

Please sign in to comment.