Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimize BrushTool #364

Merged
merged 1 commit into from
Apr 27, 2020
Merged

optimize BrushTool #364

merged 1 commit into from
Apr 27, 2020

Conversation

dlkorea
Copy link
Contributor

@dlkorea dlkorea commented Apr 24, 2020

not unites current brush path to annotation path until mouse up event is catched.

@ncianeo
Copy link

ncianeo commented Apr 24, 2020

Great job!

jsbroks
jsbroks approved these changes Apr 27, 2020
View reviewed changes
Copy link
Owner

@jsbroks jsbroks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for the help!

@jsbroks jsbroks merged commit 419d3e6 into jsbroks:master Apr 27, 2020
@geminixiang
Copy link
Contributor

not unites current brush path to annotation path until mouse up event is catched.

Amazing job

Eraser tool has the same situation,
it'll let chrome memory leak,
how to optimize it. I needs help~~

@Chaimaa-Louahabi Chaimaa-Louahabi mentioned this pull request Sep 17, 2021
Open
@Chaimaa-Louahabi
Copy link

@f416720001 I did the same optimization for the Eraser tool, You can check it here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsbroks jsbroks jsbroks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dlkorea @ncianeo @geminixiang @Chaimaa-Louahabi @jsbroks