Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silence byte compiler warnings #69

Merged
merged 4 commits into from Jan 27, 2020
Merged

Silence byte compiler warnings #69

merged 4 commits into from Jan 27, 2020

Conversation

sergeyklay
Copy link
Collaborator

@sergeyklay sergeyklay commented Jan 25, 2020

Hello,

This patch partially solve warnings described in #68.

First, it aims to fix the following warning at byte compiling time:

esup-child.el: Obsolete name arg "esup-result" to constructor esup-result

For more see: https://lists.gnu.org/archive/html/emacs-devel/2018-02/msg00342.html

Also I added missed cl-lib to the Cask file and corrected test/esup-test to require cl if Emacs <= 24.3, otherwise require cl-lib. This fixes the following warning:

Package cl is deprecated

Finally, I fixed the docsstring for esup-child-require-feature-to-filename defun.

/cc @jschaf

@sergeyklay
Copy link
Collaborator Author

Test failed at Travis. This seems is unrelated. For more see #70

@sergeyklay
Copy link
Collaborator Author

Emacs > 25.3 does not work at this time. Build at Travis CI produces the following error:

error while loading shared libraries: libgnutls.so.26:
cannot open shared object file: No such file or directory

Thus, this is disable for now. For more see: https://travis-ci.org/jschaf/esup/jobs/641742587.

Just for reference, there are no errors at GitHub Actions: https://github.com/sergeyklay/bnf-mode/actions/runs/30475202

@jschaf jschaf merged commit 9b820a3 into jschaf:master Jan 27, 2020
@jschaf
Copy link
Owner

jschaf commented Jan 27, 2020

Thanks for the PR! I merged it. I think dropping Emacs 25 support is reasonable. Debian stable is on 26.1. I've added you as a collaborator in case you'd like to keep hacking on esup.

@sergeyklay sergeyklay deleted the fix/byte-warn-ctor branch January 27, 2020 08:59
@sergeyklay
Copy link
Collaborator Author

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants