Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Byte compile warnings #68

Closed
sergeyklay opened this issue Jan 24, 2020 · 1 comment · Fixed by #75
Closed

Byte compile warnings #68

sergeyklay opened this issue Jan 24, 2020 · 1 comment · Fixed by #75

Comments

@sergeyklay
Copy link
Collaborator

Hello,

There are byte compile warnings I would like avoid to. I hope most of them are trivial. Please let me know if I can help you with this.

In esup-child-profile-string:
esup-child.el:363:16: Warning: Obsolete name arg "esup-result" to constructor
    esup-result

In esup-child-serialize-result:
esup-child.el:407:13: Warning: Unknown slot ‘:file’
esup-child.el:406:5: Warning: Unknown slot ‘:start-point’
esup-child.el:409:5: Warning: Unknown slot ‘:line-number’
esup-child.el:411:5: Warning: Unknown slot ‘:expression-string’
esup-child.el:407:47: Warning: Unknown slot ‘:end-point’
esup-child.el:408:47: Warning: Unknown slot ‘:exec-time’
esup-child.el:409:47: Warning: Unknown slot ‘:gc-number’
esup-child.el:410:47: Warning: Unknown slot ‘:gc-time’
Compiling ~/.local/share/emacs/elpa/28.0.50/esup-20200120.740/esup-pkg.el...
Compiling ~/.local/share/emacs/elpa/28.0.50/esup-20200120.740/esup.el...

In esup-total-exec-time:
esup.el:163:46: Warning: Unknown slot ‘:exec-time’

In esup-total-gc-number:
esup.el:169:46: Warning: Unknown slot ‘:gc-number’

In esup-total-gc-time:
esup.el:175:44: Warning: Unknown slot ‘:gc-time’

In esup-drop-insignificant-times:
esup.el:183:39: Warning: Unknown slot ‘:exec-time’
../../../../../../.emacs.d/site-lisp/devtools.el: ‘defmethod’ is an obsolete macro (as of 25.1); use ‘cl-defmethod’ instead.
../../../../../../.emacs.d/site-lisp/devtools.el: ‘defgeneric’ is an obsolete macro (as of 25.1); use ‘cl-defgeneric’ instead.

In esup-fontify-results:
esup.el:557:15: Warning: Unknown slot ‘:expression-string’

In esup-next-separator-end-point:
esup.el:579:35: Warning: reference to free variable
    ‘esup-child-result-separator’
@jschaf
Copy link
Owner

jschaf commented Jan 24, 2020

I remember trying to solve this in the distant past. The details are fuzzy. Those slots all exist so I'm not sure what causes the warning.

I don't use esup much anymore so I won't get to this on any reasonable timeline.

jschaf pushed a commit that referenced this issue Jan 27, 2020
* Silence byte compiler warning

See bug report: #68

For more see:
https://lists.gnu.org/archive/html/emacs-devel/2018-02/msg00342.html

* Added missed cl-lib to the Cask file

* Require cl if Emacs <= 24.3, otherwise require cl-lib

* Disable not working versions at Travis CI
This was referenced Jan 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants