Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added FTP readlines and fix storage init argument #175

Merged
merged 3 commits into from Aug 1, 2016

Conversation

Projects
None yet
3 participants
@ZuluPro
Copy link
Contributor

commented Jul 28, 2016

  • Made some fixes in FTP Storage
  • Added seek(0) to _read, for ensure readability
  • Added readlines method to FTP files
  • Added (almost) 90% coverage for FTP

ZuluPro added some commits Jul 27, 2016

@codecov-io

This comment has been minimized.

Copy link

commented Jul 28, 2016

Current coverage is 44.46% (diff: 93.75%)

Merging #175 into master will increase coverage by 13.42%

@@             master       #175   diff @@
==========================================
  Files            17         17          
  Lines          1298       1311    +13   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            403        583   +180   
+ Misses          895        728   -167   
  Partials          0          0          

Powered by Codecov. Last update 3053816...561b8ea

@jschneier jschneier merged commit 64af28d into jschneier:master Aug 1, 2016

3 checks passed

codecov/patch 93.75% of diff hit (target 31.04%)
Details
codecov/project 44.46% (+13.42%) compared to 3053816
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.