Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #513 -- Properly truncate available names when file_overwrite = True #554

Merged
merged 2 commits into from
Aug 30, 2018

Conversation

jschneier
Copy link
Owner

No description provided.

@jschneier jschneier requested a review from sww314 August 12, 2018 06:35
@jschneier
Copy link
Owner Author

Need to fix for other backends but what do we think about this approach?

@jschneier
Copy link
Owner Author

@nitely is AzureStorage affected by this? My reading is yes but there is some special _AZURE_MAX_LEN indirection in there and just want to confirm.

@nitely
Copy link
Contributor

nitely commented Aug 30, 2018

@jschneier I'm afraid it is. _AZURE_MAX_LEN just makes sure the name doesn't exceed azure's name length limit. Without it, it would raise later when uploading the file (hopefully, but I didn't try it).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants