Make hash-table support numbers as keys #431
Conversation
|
@nagy, thanks. |
|
I think a requirement for this change is that For But that doen't solve the problem for |
You are right, I will think of a different approach. |
|
May be we can store keys as strings like "TYPE:VALUE", for example "1" will be converted to "string:1" and 1 will be "number:1", etc. |
With this change, numbers are now treated as strings when setting
properties of javascript objects. This aligns with how object properties
are accessed in javascript already:
```sh
$ node
Welcome to Node.js v18.7.0.
Type ".help" for more information.
> var o = {}
undefined
> o[111] = 222
222
> o["111"]
222
>
```
Before this, the following error would be thrown.
```
CL-USER> (jscl::oset 222 (jscl::new) 111)
ERROR: activechars.join is not a function
CL-USER>
```
nagy
force-pushed
the
numbers-as-hash-keys
branch
from
284198a
to
65e4d35
Compare
|
To my surprise, that distinction between numbers and strings is already happening correctly. I have split the commit into two and added some more test and wrote some reasoning into the commit message. Please check if it is fine now. |
|
Awesome! Thanks! |
This allows numbers to be used as hash-table keys, since they are crudely converted to strings.
Closes #424