Skip to content
This repository has been archived by the owner on Dec 29, 2020. It is now read-only.

Handle jscs errors #16

Closed
wants to merge 1 commit into from
Closed

Handle jscs errors #16

wants to merge 1 commit into from

Conversation

Krinkle
Copy link

@Krinkle Krinkle commented Dec 11, 2013

  • Add failure handler to the promise for errors during the jscs process (it is a promise, so it can fail).
  • Call grunt.log.error instead of grunt.log.ok when reporting the number of failures.

Fixes #15.

@Krinkle
Handle jscs errors
9618ba2 
* Add failure handler to the promise for major errors
  during the jscs process (it is a promise, not a plain callback,
  so it can fail).

* Call grunt.log.error instead of grunt.log.ok when reporting
  the number of failures (makes the >> red instead of green
  in the output, similar to how other grunt plugins report).

* Rename variable 'i' to 'completed' to more clearly indicate
  it is incremented when an iteration is finished, not when
  it begins.

* At new line at EOF.

Fixes jscs-dev#15.
@markelog
Copy link
Member

@Krinkle can you give me an example when #15 could come up?

@Krinkle
Copy link
Author

Krinkle commented Dec 11, 2013

@markelog See issue #15, I have an example in the original report.

@gustavohenke gustavohenke mentioned this pull request Dec 11, 2013
Closed
@markelog
Copy link
Member

@Krinkle would like to apply your fix to updated code? It would be great if you could include test for #15. Or if you're too busy, i could take care of that.

@markelog markelog closed this in fe13867 Dec 22, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntax error found by jscs lib is eaten by promise, then silently passes by ending with exit code 0
2 participants
@Krinkle @markelog