This repository has been archived by the owner on Dec 29, 2020. It is now read-only.
Refactoring #17
Closed
Refactoring #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also update source code to conform with new options
Also update source code to conform with new options
| "maxlen": 100, | ||
| "eqnull": true, | ||
| "maxlen": 100, | ||
| "boss": true, |
|
Wow, lots of changes :) |
|
Some considerations:
Seems like the task is hanging like described by #15. Should we ask @Krinkle to rebase #16, or would you like to include its functionality in this branch? |
Also accept JSCS options as task options Fix jscs-dev#4
Also add "hooker" as dev dependency
Also add "reporter" option Fix jscs-dev#13
* Add setErrors method * Simplify task runner logic * Add test for JSCS#count method
Add documentation for three new options: force, reporter and reporterOutput
Right now only with code style entry Fix jscs-dev#10
Plus add tilde for "load-grunt-tasks" version
|
Landed |
|
Great, thanks. I'll update the repo to 0.3.0 (as it includes all the new cool things). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting for review:
Fixes #13,#10 (see for junit progress),#4.
Aside from that, this branch increases code coverage, makes it more flexable and easy to test, uses new
jshint,jscsoptions, adds.editorconfigfile.Plus it addes three new options:
reporter(#13),reporterOutputandforce.