Merge pull request #151 from andrewblond/bugfix/require-dot-notation

Fixed case with number for `requireDotNotation` rule
jscs-dev · Jan 10, 2014 · 9611c8f · 9611c8f
2 parents 1fe5b3e + df63e39
commit 9611c8f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 0 deletions.
diff --git a/README.md b/README.md
@@ -1614,6 +1614,7 @@ Values: `true`
 var a = b[c];
 var a = b.c;
 var a = b[c.d];
+var a = b[1];
 var a = b['while']; //reserved word
 ```
 

diff --git a/lib/rules/require-dot-notation.js b/lib/rules/require-dot-notation.js
@@ -23,6 +23,7 @@ module.exports.prototype = {
     check: function(file, errors) {
         file.iterateNodesByType('MemberExpression', function (node) {
             if (node.computed && node.property.type === 'Literal' &&
+                typeof node.property.value !== 'number' &&
                 !tokenHelper.tokenIsReservedWord(node.property)
             ) {
                 errors.add(

diff --git a/test/test.require-dot-notation.js b/test/test.require-dot-notation.js
@@ -18,6 +18,10 @@ describe('rules/require-dot-notation', function() {
         assert(checker.checkString('var x = a[\'while\']').isEmpty());
     });
 
+    it('should not report number subscription', function() {
+        assert(checker.checkString('var x = a[1]').isEmpty());
+    });
+
     it('should not report variable subscription', function() {
         assert(checker.checkString('var x = a[c]').isEmpty());
     });