This repository has been archived by the owner. It is now read-only.

[meta] Implement all styles that are being dropped from JSHint #102

Closed
mikesherov opened this Issue Dec 26, 2013 · 29 comments

Comments

Projects
None yet
@mikesherov
Contributor

mikesherov commented Dec 26, 2013

As of JSHint 3.0, all style conformance rules are being dropped: jshint/jshint#1339 . JSCS is the perfect tool to reimplement these checks. Hopefully, all can be implemented, as this will help a lot with adoption of JSCS as the defacto style checker.

Here's all the options being dropped:

...

@sindresorhus

This comment has been minimized.

Show comment
Hide comment
Member

sindresorhus commented Dec 27, 2013

👍

@doberkofler

This comment has been minimized.

Show comment
Hide comment

+1

@hnrch02

This comment has been minimized.

Show comment
Hide comment

hnrch02 commented Dec 29, 2013

👍

@mikesherov

This comment has been minimized.

Show comment
Hide comment
@mikesherov

mikesherov Dec 29, 2013

Contributor

So far, the only one that looks like it'll be difficult to implement is indent if we're trying to be smart about it, and trying to enforce some kind of ruleset about when to indent. Much easier would be simply to check that if something is indented or outdented that the right character is being used and the right number of spaces / tabs are used.

Contributor

mikesherov commented Dec 29, 2013

So far, the only one that looks like it'll be difficult to implement is indent if we're trying to be smart about it, and trying to enforce some kind of ruleset about when to indent. Much easier would be simply to check that if something is indented or outdented that the right character is being used and the right number of spaces / tabs are used.

@mikesherov

This comment has been minimized.

Show comment
Hide comment
@mikesherov

mikesherov Dec 29, 2013

Contributor

BTW, @mdevils, I promise to support and maintain all of these checks, besides for just contributing the initial features.

Contributor

mikesherov commented Dec 29, 2013

BTW, @mdevils, I promise to support and maintain all of these checks, besides for just contributing the initial features.

@markelog

This comment has been minimized.

Show comment
Hide comment
@markelog

markelog Dec 29, 2013

Member

This is awesome

Member

markelog commented Dec 29, 2013

This is awesome

@mikesherov

This comment has been minimized.

Show comment
Hide comment
@mikesherov

mikesherov Dec 29, 2013

Contributor

8 pull requests in... just 4 more to go!

Contributor

mikesherov commented Dec 29, 2013

8 pull requests in... just 4 more to go!

@mdevils

This comment has been minimized.

Show comment
Hide comment
@mdevils

mdevils Dec 30, 2013

Member

👍

Member

mdevils commented Dec 30, 2013

👍

@mdevils

This comment has been minimized.

Show comment
Hide comment
@mdevils

mdevils Dec 30, 2013

Member

BTW, @mdevils, I promise to support and maintain all of these checks, besides for just contributing the initial features.

I am very glad to hear. I working on a document for maintainers and would be glad if you join as a maintainer. You pull-requests are clear and straight.

Member

mdevils commented Dec 30, 2013

BTW, @mdevils, I promise to support and maintain all of these checks, besides for just contributing the initial features.

I am very glad to hear. I working on a document for maintainers and would be glad if you join as a maintainer. You pull-requests are clear and straight.

@mdevils

This comment has been minimized.

Show comment
Hide comment
@mdevils

mdevils Dec 30, 2013

Member

Reviewed pull requests. Accepted some, put comments to other.

Member

mdevils commented Dec 30, 2013

Reviewed pull requests. Accepted some, put comments to other.

@mikesherov

This comment has been minimized.

Show comment
Hide comment
@mikesherov

mikesherov Dec 30, 2013

Contributor

@mdevils, I'd love to be a maintainer. Just let me know what you'd like me to do and I look forward to the maintainer's document.

Contributor

mikesherov commented Dec 30, 2013

@mdevils, I'd love to be a maintainer. Just let me know what you'd like me to do and I look forward to the maintainer's document.

@mikesherov

This comment has been minimized.

Show comment
Hide comment
@mikesherov

mikesherov Dec 30, 2013

Contributor

Found one more hiding: maxlen

Contributor

mikesherov commented Dec 30, 2013

Found one more hiding: maxlen

@mikesherov

This comment has been minimized.

Show comment
Hide comment
@mikesherov

mikesherov Jan 2, 2014

Contributor

@mdevils, still working on indent, which is a bit more complex than the rest, but making good progress. Hope to have it done in the next few days! We should plan a release for when these final options land :-)

Contributor

mikesherov commented Jan 2, 2014

@mdevils, still working on indent, which is a bit more complex than the rest, but making good progress. Hope to have it done in the next few days! We should plan a release for when these final options land :-)

@mikesherov

This comment has been minimized.

Show comment
Hide comment
@mikesherov

mikesherov Jan 3, 2014

Contributor

indent posted. That's all of them!

Contributor

mikesherov commented Jan 3, 2014

indent posted. That's all of them!

@sindresorhus

This comment has been minimized.

Show comment
Hide comment
@sindresorhus

sindresorhus Jan 3, 2014

Member

Woooo!

Member

sindresorhus commented Jan 3, 2014

Woooo!

@mikesherov

This comment has been minimized.

Show comment
Hide comment
@mikesherov

mikesherov Jan 4, 2014

Contributor

Woohoo! All Merged!

Contributor

mikesherov commented Jan 4, 2014

Woohoo! All Merged!

@mikesherov

This comment has been minimized.

Show comment
Hide comment
@mikesherov

mikesherov Jan 5, 2014

Contributor

Found one more, @mdevils. This is the last of them.

Contributor

mikesherov commented Jan 5, 2014

Found one more, @mdevils. This is the last of them.

@passy

This comment has been minimized.

Show comment
Hide comment
@passy

passy Jan 8, 2014

That's fantastic! 🍰

passy commented Jan 8, 2014

That's fantastic! 🍰

@mdevils

This comment has been minimized.

Show comment
Hide comment
@mdevils

mdevils Jan 9, 2014

Member

We are almost there 👍

Member

mdevils commented Jan 9, 2014

We are almost there 👍

@mdevils

This comment has been minimized.

Show comment
Hide comment
@mdevils

mdevils Jan 9, 2014

Member

I guess we can close this issue and release a new version?

Member

mdevils commented Jan 9, 2014

I guess we can close this issue and release a new version?

@mikesherov

This comment has been minimized.

Show comment
Hide comment
@mikesherov

mikesherov Jan 9, 2014

Contributor

We can. I'd ideally like to make a jshint preset and a migration guide, as in #138 .

Perhaps we should cut the new version now as a release candidate, so people can start using it and giving us feedback, and then do a real release with documentation and any bug fixes we find in rc. @mdevils Thoughts?

Contributor

mikesherov commented Jan 9, 2014

We can. I'd ideally like to make a jshint preset and a migration guide, as in #138 .

Perhaps we should cut the new version now as a release candidate, so people can start using it and giving us feedback, and then do a real release with documentation and any bug fixes we find in rc. @mdevils Thoughts?

@mikesherov

This comment has been minimized.

Show comment
Hide comment
@mikesherov

mikesherov Jan 9, 2014

Contributor

@mdevils, also, before we cut a new version, can you merge this please: #148

Contributor

mikesherov commented Jan 9, 2014

@mdevils, also, before we cut a new version, can you merge this please: #148

@mdevils

This comment has been minimized.

Show comment
Hide comment
@mdevils

mdevils Jan 9, 2014

Member

Done 😉

Member

mdevils commented Jan 9, 2014

Done 😉

@mdevils

This comment has been minimized.

Show comment
Hide comment
@mdevils

mdevils Jan 9, 2014

Member

Version 1.2.0 is released. Thanks to Mike Sherov!

Member

mdevils commented Jan 9, 2014

Version 1.2.0 is released. Thanks to Mike Sherov!

@mdevils mdevils closed this Jan 9, 2014

@MoOx

This comment has been minimized.

Show comment
Hide comment
@MoOx

MoOx Jan 13, 2014

This is just awesome. Thanks for you works guys !

MoOx commented Jan 13, 2014

This is just awesome. Thanks for you works guys !

@nschonni

This comment has been minimized.

Show comment
Hide comment
@nschonni

nschonni Jan 17, 2014

Contributor

Not sure if plusplus is on the chopping block, but it might be a good fit here.

Contributor

nschonni commented Jan 17, 2014

Not sure if plusplus is on the chopping block, but it might be a good fit here.

@mikesherov

This comment has been minimized.

Show comment
Hide comment
@mikesherov

mikesherov Jan 17, 2014

Contributor

https://github.com/jshint/jshint/blob/37757f0195e9ee4eb4bd8aeb5162c2a3c1565832/src/options.js#L45 plusplus is surviving to 3.0 Our design goals have always been to compliment JSHint, rather than duplicate it, so we're not going to implement this one. @antonkovalyov, you guys are keeping plusplus, right?

@nschonni also, if it turns out it is being cut, please open a new issue instead of appending onto this one. Thanks!

Contributor

mikesherov commented Jan 17, 2014

https://github.com/jshint/jshint/blob/37757f0195e9ee4eb4bd8aeb5162c2a3c1565832/src/options.js#L45 plusplus is surviving to 3.0 Our design goals have always been to compliment JSHint, rather than duplicate it, so we're not going to implement this one. @antonkovalyov, you guys are keeping plusplus, right?

@nschonni also, if it turns out it is being cut, please open a new issue instead of appending onto this one. Thanks!

@valueof

This comment has been minimized.

Show comment
Hide comment
@valueof

valueof Jan 18, 2014

I don't remember why I kept it. I'll re-visit it and will let you know asap.

valueof commented Jan 18, 2014

I don't remember why I kept it. I'll re-visit it and will let you know asap.

@mikesherov mikesherov referenced this issue in twbs/bootstrap Feb 26, 2014

Merged

Switch to JSCS #12853

4 of 4 tasks complete

kamrik added a commit to kamrik/cordova-lib that referenced this issue Aug 1, 2014

Add JSCS config file
Don't merge yet - feedback wanted.

JSHint people want to focus on syntax linting and are dropping style oriented
options. They recommends using JSCS (in addition to JSHint) for style:
jshint/jshint#1339

JSCS has recently added the options dropped from JSHint.
jscs-dev/node-jscs#102

This commit contains a JSCS config file with some basic settings that generate
very few errors with the existing cordova-cli and lib code.

Would be glad to get some feedback about this. My goal is to eventually run
JSCS together with JSHint as part of `npm test`. The nice thing about JSCS
is that style flame wars can be way more structured with it as we can argue
about very specific well named JSCS config options :)

I'm using it with SublimeLinter-jscs
https://sublime.wbond.net/packages/SublimeLinter-jscs

kamrik added a commit to kamrik/cordova-lib that referenced this issue Aug 1, 2014

Add JSCS config file
Don't merge yet - feedback wanted.

JSHint people want to focus on syntax linting and are dropping style oriented
options. They recommends using JSCS (in addition to JSHint) for style:
jshint/jshint#1339

JSCS has recently added the options dropped from JSHint.
jscs-dev/node-jscs#102

This commit contains a JSCS config file with some basic settings that generate
very few errors with the existing cordova-cli and lib code.

Would be glad to get some feedback about this. My goal is to eventually run
JSCS together with JSHint as part of `npm test`. The nice thing about JSCS
is that style flame wars can be way more structured with it as we can argue
about very specific well named JSCS config options :)

I'm using it with SublimeLinter-jscs
https://sublime.wbond.net/packages/SublimeLinter-jscs

@kamrik kamrik referenced this issue in apache/cordova-lib Aug 1, 2014

Closed

Add JSCS config file #69

asfgit pushed a commit to apache/cordova-lib that referenced this issue Aug 6, 2014

Add JSCS config file
But not running it as part of `npm test` yet.

See discussion here:
http://markmail.org/thread/rzzvn2ax3tqzabfw

JSHint people want to focus on syntax linting and are dropping style oriented
options. They recommends using JSCS (in addition to JSHint) for style:
jshint/jshint#1339

JSCS has recently added the options dropped from JSHint.
jscs-dev/node-jscs#102

This commit contains a JSCS config file with some basic settings that generate
very few errors with the existing cordova-cli and lib code.

My goal is to eventually run JSCS together with JSHint as part of `npm test`.
The nice thing about JSCS is that style flame wars can be way more structured
with it as we can argue about very specific well named JSCS config options :)

I'm using it with SublimeLinter-jscs
https://sublime.wbond.net/packages/SublimeLinter-jscs

asfgit pushed a commit to apache/cordova-lib that referenced this issue Sep 5, 2014

Add JSCS config file
But not running it as part of `npm test` yet.

See discussion here:
http://markmail.org/thread/rzzvn2ax3tqzabfw

JSHint people want to focus on syntax linting and are dropping style oriented
options. They recommends using JSCS (in addition to JSHint) for style:
jshint/jshint#1339

JSCS has recently added the options dropped from JSHint.
jscs-dev/node-jscs#102

This commit contains a JSCS config file with some basic settings that generate
very few errors with the existing cordova-cli and lib code.

My goal is to eventually run JSCS together with JSHint as part of `npm test`.
The nice thing about JSCS is that style flame wars can be way more structured
with it as we can argue about very specific well named JSCS config options :)

I'm using it with SublimeLinter-jscs
https://sublime.wbond.net/packages/SublimeLinter-jscs
@popomore

This comment has been minimized.

Show comment
Hide comment

Great!

@ophite ophite referenced this issue in biosis21/angular-skeleton Sep 1, 2015

Merged

use instead of jshint -> jscs #5

matt-oakes pushed a commit to matt-oakes/cordova-lib-watchos that referenced this issue Apr 3, 2017

Add JSCS config file
But not running it as part of `npm test` yet.

See discussion here:
http://markmail.org/thread/rzzvn2ax3tqzabfw

JSHint people want to focus on syntax linting and are dropping style oriented
options. They recommends using JSCS (in addition to JSHint) for style:
jshint/jshint#1339

JSCS has recently added the options dropped from JSHint.
jscs-dev/node-jscs#102

This commit contains a JSCS config file with some basic settings that generate
very few errors with the existing cordova-cli and lib code.

My goal is to eventually run JSCS together with JSHint as part of `npm test`.
The nice thing about JSCS is that style flame wars can be way more structured
with it as we can argue about very specific well named JSCS config options :)

I'm using it with SublimeLinter-jscs
https://sublime.wbond.net/packages/SublimeLinter-jscs

matt-oakes pushed a commit to matt-oakes/cordova-lib-watchos that referenced this issue Apr 3, 2017

Add JSCS config file
But not running it as part of `npm test` yet.

See discussion here:
http://markmail.org/thread/rzzvn2ax3tqzabfw

JSHint people want to focus on syntax linting and are dropping style oriented
options. They recommends using JSCS (in addition to JSHint) for style:
jshint/jshint#1339

JSCS has recently added the options dropped from JSHint.
jscs-dev/node-jscs#102

This commit contains a JSCS config file with some basic settings that generate
very few errors with the existing cordova-cli and lib code.

My goal is to eventually run JSCS together with JSHint as part of `npm test`.
The nice thing about JSCS is that style flame wars can be way more structured
with it as we can argue about very specific well named JSCS config options :)

I'm using it with SublimeLinter-jscs
https://sublime.wbond.net/packages/SublimeLinter-jscs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.