[meta] Implement all styles that are being dropped from JSHint

[mikesherov]

As of JSHint 3.0, all style conformance rules are being dropped: jshint/jshint#1339 . JSCS is the perfect tool to reimplement these checks. Hopefully, all can be implemented, as this will help a lot with adoption of JSCS as the defacto style checker.

Here's all the options being dropped:

• gcl: not necessary as it was a relaxing option for "white"
• white: already covered by the various JSCS options
• onevar: already covered by existing JSCS options
• PR Add requireDotNotation rule #115 sub: http://www.jshint.com/docs/options/#sub
• PR Adds requireOperatorBeforeLineBreak, closes #104 #114 laxbreak: http://www.jshint.com/docs/options/#laxbreak require safe line breaks #104
• PR Add comma and line break rules #113 laxcomma: http://www.jshint.com/docs/options/#laxcomma require succeeding commas #103 && enforce preceding commas #66
• PR Add disallowTrailingWhitespace rules, closes #105 #110 trailing: http://www.jshint.com/docs/options/#trailing disallow trailing whitespace #105
• PR Add validateQuoteMarks rule, closes #106 #118 quotmark: http://www.jshint.com/docs/options/#quotmark require consistent quote marks #106
• PR add requireCapitalizedConstructors rule #119 newcap: http://www.jshint.com/docs/options/#newcap
• PR add disallowDanglingUnderscores rule #120 nomen: http://www.jshint.com/docs/options/#nomen
• PR add requireCamelCaseOrUpperCaseIdentifiers rule #121 camelcase: http://www.jshint.com/docs/options/#camelcase
• PR Add disallowEmptyBlocks rule #122 noempty: http://www.jshint.com/docs/options/#noempty
• PR Add requireParenthesesAroundIIFE rule #123 immed: http://www.jshint.com/docs/options/#immed
• PR add disallowMixedSpacesAndTabs rule #134 smarttabs: Whitespace checker #60 http://www.jshint.com/docs/options/#smarttabs
• PR add MaximumLineLength rule #135 maxlen: http://www.jshint.com/docs/options/#maxlen
• PR add validateIndentation rule, closes #60 #137 indent: Whitespace checker #60 http://www.jshint.com/docs/options/#indent
• PR add multipleLineStrings rule, closes #141 #142 multistr: port JSHint multistr rule. #141 http://www.jshint.com/docs/options/#multistr

...

[sindresorhus]

👍

[doberkofler]

+1

[hnrch02]

👍

[mikesherov]

So far, the only one that looks like it'll be difficult to implement is indent if we're trying to be smart about it, and trying to enforce some kind of ruleset about when to indent. Much easier would be simply to check that if something is indented or outdented that the right character is being used and the right number of spaces / tabs are used.

[mikesherov]

BTW, @mdevils, I promise to support and maintain all of these checks, besides for just contributing the initial features.

[markelog]

This is awesome

[mikesherov]

8 pull requests in... just 4 more to go!

[mdevils]

👍

[mdevils]

BTW, @mdevils, I promise to support and maintain all of these checks, besides for just contributing the initial features.

I am very glad to hear. I working on a document for maintainers and would be glad if you join as a maintainer. You pull-requests are clear and straight.

[mdevils]

Reviewed pull requests. Accepted some, put comments to other.

[mikesherov]

@mdevils, I'd love to be a maintainer. Just let me know what you'd like me to do and I look forward to the maintainer's document.

[mikesherov]

Found one more hiding: maxlen

[mikesherov]

@mdevils, still working on indent, which is a bit more complex than the rest, but making good progress. Hope to have it done in the next few days! We should plan a release for when these final options land :-)

[mikesherov]

indent posted. That's all of them!

[sindresorhus]

Woooo!

[mikesherov]

Woohoo! All Merged!

[mikesherov]

Found one more, @mdevils. This is the last of them.

[passy]

That's fantastic! 🍰

[mdevils]

We are almost there 👍

[mdevils]

I guess we can close this issue and release a new version?

[mikesherov]

We can. I'd ideally like to make a jshint preset and a migration guide, as in #138 .

Perhaps we should cut the new version now as a release candidate, so people can start using it and giving us feedback, and then do a real release with documentation and any bug fixes we find in rc. @mdevils Thoughts?

[mikesherov]

@mdevils, also, before we cut a new version, can you merge this please: #148

[mdevils]

Done 😉

[mdevils]

Version 1.2.0 is released. Thanks to Mike Sherov!

[MoOx]

This is just awesome. Thanks for you works guys !

[nschonni]

Not sure if plusplus is on the chopping block, but it might be a good fit here.

[mikesherov]

https://github.com/jshint/jshint/blob/37757f0195e9ee4eb4bd8aeb5162c2a3c1565832/src/options.js#L45 plusplus is surviving to 3.0 Our design goals have always been to compliment JSHint, rather than duplicate it, so we're not going to implement this one. @antonkovalyov, you guys are keeping plusplus, right?

@nschonni also, if it turns out it is being cut, please open a new issue instead of appending onto this one. Thanks!

[valueof]

I don't remember why I kept it. I'll re-visit it and will let you know asap.

[popomore]

Great!