Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

add validateIndentation rule, closes #60 #137

Merged
merged 1 commit into from
Jan 4, 2014
Merged

add validateIndentation rule, closes #60 #137

merged 1 commit into from
Jan 4, 2014

Conversation

mikesherov
Copy link
Contributor

No description provided.

@mikesherov mikesherov restored the indent branch January 3, 2014 17:38
This was referenced Jan 3, 2014
Closed
Closed
@mikesherov
Copy link
Contributor Author

@mdevils this is a pretty big one, but it copies JSHint's functionality, and this is what we should land. If we want to improve or change the rule later, I'm open to that, but I'd like to see the rule land as is without modifying its intent. This is the last PR before we've completed #102 !

@mdevils
Copy link
Member

mdevils commented Jan 4, 2014

Can you rebase please?

@mikesherov
Copy link
Contributor Author

@mdevils, I'll be home in around 4 hours. I can do it then.

@mikesherov
Copy link
Contributor Author

Rebased! @mdevils, this should be ready now!

mdevils added a commit that referenced this pull request Jan 4, 2014
@mdevils
Merge pull request #137 from mikesherov/indent
3c05ef2 
add validateIndentation rule, closes #60
@mdevils mdevils merged commit 3c05ef2 into jscs-dev:master Jan 4, 2014
@mdevils
Copy link
Member

mdevils commented Jan 4, 2014

Thank you!

@mikesherov mikesherov deleted the indent branch January 5, 2014 17:31
@janraasch janraasch mentioned this pull request Jan 13, 2014
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikesherov @mdevils