Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

requireSpacesInsideObjectBrackets using inconsistent terminology #538

Closed
cowwoc opened this issue Jul 24, 2014 · 8 comments
Closed

requireSpacesInsideObjectBrackets using inconsistent terminology #538

cowwoc opened this issue Jul 24, 2014 · 8 comments

Comments

@cowwoc
Copy link

cowwoc commented Jul 24, 2014

The terminology of requireSpacesInsideObjectBrackets is inconsistent. The rule refers to "brackets" but the description (and other rules) refer to this character as curly braces.

Consider renaming the rule or description to make this more consistent.

@SgtPooki
Copy link

Looking into this

SgtPooki pushed a commit to SgtPooki/node-jscs that referenced this issue Aug 28, 2014
…and object-brackets in filenames to curly-braces
@markelog
Copy link
Member

Can't do this until 2.0 :-(

@markelog
Copy link
Member

Ooops, wrong issue to close

@markelog markelog reopened this Aug 29, 2014
@SgtPooki
Copy link

@markelog @mikesherov Do you want me to add the rule and deprecate it or would that also have to wait until 2.0?

Also, when are you planning to have 2.0 out? I will continue trying to help with help-wanted labelled bugs and 2.0 milestones, so let me know if there are any issues you specifically want me to work on.

@markelog
Copy link
Member

I think we could land this as is, although i hope that would not result in a lot of conflicts with 1.x.

Also, when are you planning to have 2.0 out?

There is no dead line.

I will continue trying to help with help-wanted labelled bugs and 2.0 milestones, so let me know if there are any issues you specifically want me to work on.

@mdevils ?

@mdevils
Copy link
Member

mdevils commented Aug 29, 2014

I'm working on 2.x concept. I will keep in mind that you are ready to help. There will be some tasks soon.

@qfox
Copy link
Member

qfox commented Aug 29, 2014

@mdevils Keep waiting! Thanks!

@mikesherov mikesherov added this to the 2.0 milestone Nov 29, 2014
@markelog markelog modified the milestones: 2.0, 3.0 Jul 15, 2015
@hzoo hzoo added the new format label Aug 9, 2015
@hzoo hzoo mentioned this issue Oct 2, 2015
14 tasks
@hzoo
Copy link
Member

hzoo commented Oct 2, 2015

Moving to #1834 - let me know/change it if it's moved over incorrectly.

@hzoo hzoo closed this as completed Oct 2, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
7 participants