Skip to content
This repository has been archived by the owner on Mar 23, 2024. It is now read-only.

Added JSON reporter #1559

Closed
wants to merge 1 commit into from
Closed

Conversation

romanblanco
Copy link
Contributor

New reporter that returns errors in JSON format

@mrjoelkemp
Copy link
Member

Nice work here @romanblanco. Thanks for contributing! LGTM

@markelog
Copy link
Member

It seems amount of reporters grows pretty fast, we need to be more conservative here.

LGTM

@markelog
Copy link
Member

btw, what is use-case for this?

@romanblanco
Copy link
Contributor Author

@markelog we need JSON output to be able to integrate jscs to GitHub bot for pull request monitoring.

@markelog
Copy link
Member

Isn't that easier to use API for that sort of thing? What do you do for other runners?

@markelog
Copy link
Member

?

@romanblanco
Copy link
Contributor Author

@markelog What API do you mean?

@markelog
Copy link
Member

markelog commented Aug 7, 2015

Lets start from the other end, how do get that info from the other linters? Like jshint, eslint?

@markelog
Copy link
Member

markelog commented Aug 7, 2015

fyi, we probably gonna release this with 2.1 version, i would like to just better understand your use-case

@romanblanco
Copy link
Contributor Author

@markelog till this time, we only used haml-lint and rubocop linters in our GitHub bot (which has similar use to https://www.houndci.com/), as you can see here. They both provide JSON output. We would like to use other linters, which means, we need to either make a wrapper to output linter results in JSON, or add another reporter right into linter.

@markelog
Copy link
Member

And you don't want to provide global/relative reporter for the --reporter flag?

@romanblanco
Copy link
Contributor Author

Which global/relative reporter flag you got on mind? I don't quite understand that question.

@markelog
Copy link
Member

@romanblanco
Copy link
Contributor Author

Well, yes. I probably could specify my own reporter, if it would be problem to add another into node-jscs. I didn't noticed this option before.

added reporter that sends output in JSON format
@markelog
Copy link
Member

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants