-
Notifications
You must be signed in to change notification settings - Fork 513
Conversation
4c89a9d
to
6934a40
Compare
Nice work here @romanblanco. Thanks for contributing! LGTM |
It seems amount of reporters grows pretty fast, we need to be more conservative here. LGTM |
btw, what is use-case for this? |
@markelog we need JSON output to be able to integrate jscs to GitHub bot for pull request monitoring. |
Isn't that easier to use API for that sort of thing? What do you do for other runners? |
? |
@markelog What API do you mean? |
6934a40
to
f513c22
Compare
Lets start from the other end, how do get that info from the other linters? Like jshint, eslint? |
fyi, we probably gonna release this with 2.1 version, i would like to just better understand your use-case |
@markelog till this time, we only used haml-lint and rubocop linters in our GitHub bot (which has similar use to https://www.houndci.com/), as you can see here. They both provide JSON output. We would like to use other linters, which means, we need to either make a wrapper to output linter results in JSON, or add another reporter right into linter. |
And you don't want to provide global/relative reporter for the |
Which global/relative reporter flag you got on mind? I don't quite understand that question. |
Well, yes. I probably could specify my own reporter, if it would be problem to add another into node-jscs. I didn't noticed this option before. |
added reporter that sends output in JSON format
f513c22
to
03d168e
Compare
Thank you! |
New reporter that returns errors in JSON format