This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
Update jscs-jsdoc to 1.3.0 #2009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So to be dependant on itself o_0? |
|
Okay, talked with @zxqfox, we decided to remove that peer dep, we will land this right after the release of the |
|
Awesome, that sounds great! I don't have an opinion on the peerDep, I just want 1.3.0 or higher :-D |
qfox
added a commit
to jscs-dev/jscs-jsdoc
that referenced
this pull request
Dec 8, 2015
hzoo
pushed a commit
to hzoo/node-jscs
that referenced
this pull request
Jan 27, 2016
hzoo
pushed a commit
to hzoo/node-jscs
that referenced
this pull request
Jan 27, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes jscs-dev/jscs-jsdoc#179 which includes syavorsky/comment-parser#24 (comment). Since this PR also properly includes a semver range identifier, fixes of this type (for comment-parser and jscs-jsdoc) should no longer require corresponding PRs across the dependency graph :-)
This will hopefully make jscs work on node 0.8 (that doesn't mean you have to officially support it!) and if not, will at least remove one bottleneck so I can pursue the others.
jscsis included becausejscs-jsdocapparently now requires it as a peerDep.