This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
TESTS: Don't use exec for testing stdin. Modify process.stdin directly. Fixes #547 #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| // Simulate buffered stdin by delaying before sending the next chunk | ||
| // of data. Note: this arbitrary timeout appears to be the only way | ||
| // to reliably trigger two 'data' events on cmd's stdin. | ||
| setTimeout(function() { | ||
| cmd.stdin.end('a = 1;\n'); | ||
| process.stdin.emit('data', 'var a = 1;\n'); |
There was a problem hiding this comment.
@benesch hey, since you can just do process.stdin.emit('data', ...), do we still need the timeout of half a second?
Seems like two things are going on here:
- The timeout simulates a delay in data buffering
- The timeout is stated to be used because of the lack of being able to trigger two 'data' events. I don't believe this is the case.
If it turns out that case 2 is no longer valid, and if you agree, I will decrease the timeout to avoid unnecessarily slowing down the suite.
|
Awesome, can't wait to land it |
|
Merged, thank you |
|
Hm, after merging this and #594 one test is now falling, could you take a look? |
|
Will do. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids using
execforstdintests by manipulatingprocess.stdinin the tests and emitting events onprocess.stdinto trigger stdin parsing in the cli. This speeds up the test suite considerably.