This repository has been archived by the owner on Mar 23, 2024. It is now read-only.
Remove underscore option name error reporting #654
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM if it's definitely not used elsewhere in the codebase. |
|
Yey! This config style probably not used in any projects. But :-(, this will break backward-compatibility, which we are allowed to do only in 2.0. |
mdevils
force-pushed
the
mdevils.camel-case
branch
from
13d35db
to
c70fec7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was an old-old story happened in one of the first releases of
jscswhen we changed option names fromuderscore_styletocamelCaseStyle.I believe we can just remove that validation.