Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(semver): drop standard-version + all conventional-changelog config #618

Conversation

nowseemee
Copy link
Contributor

@nowseemee nowseemee commented Oct 28, 2022

Yo, this tool is awesome, thanks for it! 💫💫💫

Description

I have a project at Azure DevOps Repos (don't ask why) and the default diff link pattern of the generated change log was off. So...

About the PR:

@nowseemee nowseemee force-pushed the feat/drop-standed-version-and-enable-all-conventional-changelog-config branch from 1e81dc8 to b76afc0 Compare October 28, 2022 23:08
@nowseemee nowseemee force-pushed the feat/drop-standed-version-and-enable-all-conventional-changelog-config branch from b76afc0 to 92ca3ae Compare October 28, 2022 23:17
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #618 (8588898) into main (c86b80a) will increase coverage by 0.32%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #618      +/-   ##
==========================================
+ Coverage   97.13%   97.46%   +0.32%     
==========================================
  Files          26       28       +2     
  Lines         559      592      +33     
  Branches       94       97       +3     
==========================================
+ Hits          543      577      +34     
  Misses          8        8              
+ Partials        8        7       -1     
Impacted Files Coverage Δ
packages/semver/src/executors/version/version.ts 100.00% <ø> (ø)
packages/semver/src/executors/version/index.ts 98.24% <100.00%> (+0.03%) ⬆️
...es/semver/src/executors/version/utils/changelog.ts 100.00% <100.00%> (+3.33%) ⬆️
.../utils/init-conventional-commit-readable-stream.ts 100.00% <100.00%> (ø)
...ver/src/executors/version/utils/write-changelog.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@nowseemee nowseemee force-pushed the feat/drop-standed-version-and-enable-all-conventional-changelog-config branch from 21b4b6c to bea078e Compare October 29, 2022 00:56
@nowseemee nowseemee force-pushed the feat/drop-standed-version-and-enable-all-conventional-changelog-config branch 4 times, most recently from 319dd9d to e2f60bc Compare October 29, 2022 17:33
@nowseemee nowseemee force-pushed the feat/drop-standed-version-and-enable-all-conventional-changelog-config branch from e2f60bc to 8588898 Compare October 29, 2022 17:36
@edbzn
Copy link
Member

edbzn commented Nov 5, 2022

Hey, I'm in hollidays and back pretty soon! I'm excited to check your work. Thanks in advance.

@nowseemee
Copy link
Contributor Author

Hey, I hope you are having a good one! Take your time, work can wait :)

@edbzn edbzn merged commit b3fe315 into jscutlery:main Nov 14, 2022
@edbzn
Copy link
Member

edbzn commented Nov 14, 2022

@nowseemee Thanks a lot for the work!

@nowseemee nowseemee deleted the feat/drop-standed-version-and-enable-all-conventional-changelog-config branch November 14, 2022 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants