Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sourceMappingURL files 403 response #629

Closed
thebeebs opened this issue Feb 2, 2016 · 34 comments
Closed

sourceMappingURL files 403 response #629

thebeebs opened this issue Feb 2, 2016 · 34 comments
Assignees
@jdorfman
Labels
bug todo

Comments

@thebeebs
Copy link

thebeebs commented Feb 2, 2016

I was just investigating this issue on stackoverflow http://stackoverflow.com/questions/35142485/why-is-bootstrap-trying-to-load-less-files-in-ie-edge/35151109#35151109 and it became apparent that the less files declared in the bootstrap.min.css.map file are 403'ing

This is currently breaking SourceMap debugging in browser tools such as Edge and Chrome F12 tools.
@patrickhlauke patrickhlauke mentioned this issue Feb 2, 2016
Closed
@jmervine
Copy link
Contributor

jmervine commented Feb 2, 2016

@thebeebs Thanks for bringing this to our attention. It might take a little bit, but we'll resolve.

@jdorfman
Copy link
Member

jdorfman commented Feb 2, 2016

EDIT

@thebeebs as @jmervine said thanks for reporting this. I will see if I can reach anyone on the Edge team.

The source map file will only be downloaded if you have source maps enabled and your dev tools open.

Got it. I have been against hosting anything but .js & .css and now I am seeing it as an anti-dev friendly move, which we are not about.

@jmervine let's talk about this offline and make a decision.

@thebeebs
Copy link
Author

thebeebs commented Feb 2, 2016

Another option would be to remove the sourcemapurl comment from the css file or in the map file provide full urls to the files on GitHub (they don't have to be hosted on your cdn)

@jmervine
Copy link
Contributor

jmervine commented Feb 3, 2016

@thebeebs I thought about that. I don't know that it's a valid option long term as our general policy is not to modify files that come from our sources, aside from perhaps minifying where necessary. That said, if @jdorfman is cool with it, we could consider doing it as a stop gap.

@jdorfman
Copy link
Member

jdorfman commented Feb 4, 2016

@jmervine correct I don't want to change that policy, I rather just start delivering the .less files. So we just need to adjust the current workflow.

@jmervine
Copy link
Contributor

jmervine commented Feb 4, 2016

I'll work on something this weekend to batch update the perms for *.less files on the origin.

@jdorfman
Copy link
Member

jdorfman commented Feb 4, 2016

👍

@nebeleh
Copy link

nebeleh commented Feb 10, 2016

any updates on the issue? I do have the same problem.

@jmervine
Copy link
Contributor

@nebeleh No sorry, I didn't get to this. I will though. Thanks for the ping as a reminder. :D

@jmervine
Copy link
Contributor

@jdorfman @nebeleh This is actually a bit more work to resolve. The issue is, we haven't in the past uploaded less files to the s3 bucket, and there's quite a few spread through out. I'll get to it, but probably not this week. I'll shoot for the weekend.

Cheers!
J

@jmervine
Copy link
Contributor

Okay, I've uploaded and verified perms on all .map, .less and .scss files. Please open an new issue, or reopen this one if you come across anything else that's missing / incorrect.

@jdorfman
Copy link
Member

@thebeebs @nebeleh please confirm. Thanks!

@nebeleh
Copy link

nebeleh commented Feb 12, 2016

Thank you for checking on this. Although I still do have some issues, especially when using Edge. I'm using bower to load up bootstrap from https://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/js/bootstrap.min, but I receive this error in console: HTTP404: NOT FOUND - The server has not found anything matching the requested URI (Uniform Resource Identifier). (XHR): GET - http://.../bower_components/bootstrap/dist/css/less/normalize.less plus a similar message for many other .less files inside bootstrap. It may not have any actual effect on the final code, yet it would be nice if I can resolve them. Should I use a different version for the CDN?

@patrickhlauke
Copy link

capture

Just confirming that it's still 403-ing all over the place. Is there something that needs to be enabled at Bootstrap's end? See twbs/bootstrap#19063 (comment)

@jdorfman
Copy link
Member

@patrickhlauke thanks. @jmervine and I will keep digging in.

@jdorfman
Copy link
Member

@patrickhlauke @cvrebert would it be possible to remove /*# sourceMappingURL=bootstrap-theme.min.css.map */ from the .min files on build?

Or at least help me understand why it is necessary?

We prefer to serve the exact file from GitHub so everyone can be assured that we are not injecting anything, hence why we leave it in.

Thanks!

@cvrebert
Copy link
Contributor

Assuming we can rejigger the sourcemap to not reference external Less filepaths (which I believe is possible; see twbs/bootstrap#19063), it shouldn't be necessary to disable/remove sourcemaps from the CSS (nor to host any Less files).

@jdorfman
Copy link
Member

@cvrebert that would be ideal. Let us know if we can be of help in anyway.

@Codare
Copy link

Codare commented May 31, 2016

This issue is happening to me right now in Edge browser tools.
This is my href: http://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css
http://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/less/normalize.less
Lots of 403 errors.

@jmervine
Copy link
Contributor

@jdorfman I was able to reproduce on iOS Chrome for the bottom link, but
not top. I can fix that within the hour if you don't get to it first.

J
On Tue, May 31, 2016 at 02:38 Adrian Cooke notifications@github.com wrote:

This issue is happening to me right now in Edge browser tools.

This is my href:
http://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css
http://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/less/normalize.less
Lots of 403 errors.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#629 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AAzJBTjwHSfQyqKLG-N4ZpnS8hIa6rkyks5qHAGlgaJpZM4HRXGL
.

@jmervine
Copy link
Contributor

jmervine commented May 31, 2016 •
edited

@wingnut808 You're getting 403 on http://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/less/normalize.less, because we don't provide that file and 403 is the default response for a missing file in AWS S3. As for http://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css, I verified the perms on it and they look right... mind running a quick curl HEAD request and dumping me the output... for example...

jmervine@laptop:~$ curl -s -I http://maxcdn.bootstrapcdn.com/bootstrap/3.3.6/css/bootstrap.min.css
HTTP/1.1 200 OK
Date: Tue, 31 May 2016 14:46:13 GMT
Content-Type: text/css
Content-Length: 121260
Connection: keep-alive
Last-Modified: Tue, 24 Nov 2015 19:49:46 GMT
ETag: "2f624089c65f12185e79925bc5a7fc42"
Server: NetDNA-cache/2.2
Expires: Fri, 26 May 2017 14:46:13 GMT
Cache-Control: max-age=31104000
Vary: Accept-Encoding
Access-Control-Allow-Origin: *
X-Hello-Human: You should work for us! Email: jdorfman+theheader@maxcdn.com or @MaxCDNDeveloper on Twitter
X-Cache: HIT
Accept-Ranges: bytes

@jdorfman I know we discussed providing development files and thought we decided to, start including them moving forward. Can you confirm?

@cvrebert
Copy link
Contributor

Sorry folks. I'll try to take another look at twbs/bootstrap#19063 soon.

@jmervine
Copy link
Contributor

@cvrebert No worries, thanks for jogging my memory on it. I knew we had a solution, but I couldn't remember what it was.

@jdorfman
Copy link
Member

@jmervine it is strictly a Edge issue, which isn't really their fault. Chrome ignores the 4xx errors. Hopefully twbs/bootstrap#19063 fixes it for future releases.

@jdorfman jdorfman mentioned this issue Jun 6, 2016
Closed
@jdorfman jdorfman self-assigned this Jun 6, 2016
@jdorfman
Copy link
Member

jdorfman commented Jun 6, 2016

I am reopening this until twbs/bootstrap#19063 is resolved.

@jdorfman jdorfman reopened this Jun 6, 2016
@bhavik3184
Copy link

+1 for me its failing on Edge!! :(

@ryuker16
Copy link

ryuker16 commented Jul 5, 2016

happening to me as well on all browsers

@jdorfman
Copy link
Member

jdorfman commented Jul 5, 2016

@bhavik3184 @ryuker16 copy that. I will do my best to get this resolved.

@jdorfman jdorfman mentioned this issue Jul 8, 2016
Merged
@jdorfman
Copy link
Member

jdorfman commented Jul 8, 2016

@thebeebs @nebeleh @patrickhlauke @wingnut808 @ryuker16 @bhavik3184 please test this: https://maxcdn.bootstrapcdn.com/debug/fix-19063-v3/css/bootstrap.min.css and report whether it works or not. Thanks.

@jdorfman
Copy link
Member

Looks like this will be resolved soon. @XhmikosR confirmed that @cvrebert's fix worked.

No more 4xx errors:
image

@jeherve jeherve mentioned this issue Jul 18, 2016
Closed
@cvrebert
Copy link
Contributor

@jdorfman So, we done here, now that 3.3.7 is out with the fix?

@jdorfman
Copy link
Member

@cvrebert yes. Thanks to everyone involved. I'm having issues updating the BootstrapCDN homepage so here you go:

<!-- Latest compiled and minified CSS -->
<link rel="stylesheet" href="//maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css" integrity="sha384-BVYiiSIFeK1dGmJRAkycuHAHRg32OmUcww7on3RYdg4Va+PmSTsz/K68vbdEjh4u" crossorigin="anonymous">

<!-- Optional theme -->
<link rel="stylesheet" href="//maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap-theme.min.css" integrity="sha384-rHyoN1iRsVXV4nD0JutlnGaslCJuC7uwjduW9SVrLvRYooPp2bWYgmgJQIXwl/Sp" crossorigin="anonymous">

<!-- Latest compiled and minified JavaScript -->
<script src="//maxcdn.bootstrapcdn.com/bootstrap/3.3.7/js/bootstrap.min.js" integrity="sha384-Tc5IQib027qvyjSMfHjOMaLkfuWVxZxUPnCJA7l2mCWNIpG9mGCD8wGNIcPD7Txa" crossorigin="anonymous"></script>

jonuy pushed a commit to shinetext/web-content-styles that referenced this issue Aug 23, 2016
Upgrading bootstrap to 3.3.7 in an attempt to fix 403 issues when loa…
4d3f296 
…ding styles in Safari

- Seems like it might happen in Edge too though I haven't been able to get it to happen on any of my machines yet: jsdelivr/bootstrapcdn#629
- Also some minor copy changes
@jonuy jonuy mentioned this issue Aug 23, 2016
Merged
MrFlick added a commit to statgen/encore that referenced this issue Feb 10, 2017
@MrFlick
Bump to bootstrap 3.3.7
5e917d6 
Mostly helps to eliminate unhelpful errors in Edge per
this issue jsdelivr/bootstrapcdn#629
@gitwith
Copy link

gitwith commented Jul 17, 2017 •
edited

I still get the errors with debugger in ie11 when specifying: https://maxcdn.bootstrapcdn.com/bootstrap/latest/css/bootstrap.min.css

It complains of missing links from map file:
"Could not locate https://maxcdn.bootstrapcdn.com/bootstrap/latest/css/less/print.less in source map https://maxcdn.bootstrapcdn.com/bootstrap/latest/css/bootstrap.min.css.map"

@jdorfman
Copy link
Member

@gitwith we don't add bootstrap.min.css.map to /latest/. Please choose /3.3.7/

@kwight kwight mentioned this issue Apr 4, 2018
Open
@zfi zfi mentioned this issue Dec 13, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdorfman jdorfman

Labels
bug todo
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@jdorfman @cvrebert @thebeebs @jmervine @patrickhlauke @Codare @nebeleh @ryuker16 @bhavik3184 @gitwith