Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the unicode symbols when possible. #839

Merged
merged 1 commit into from Dec 28, 2016
Merged

Use the unicode symbols when possible. #839

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion routes/index.js
View file
Open in desktop
Expand Up @@ -20,7 +20,7 @@ function appendLocals(req, res) {
res.locals.theme = req.query.theme;

res.locals.displayTitle = function (pageTitle) {
return pageTitle + ' · ' + TITLE;
return pageTitle + ' · ' + TITLE;
};

res.locals.bodyClass = function (pageTitle) {
Expand Down
3 changes: 2 additions & 1 deletion views/_partials/header.pug
View file
Open in desktop
Expand Up @@ -27,7 +27,8 @@
li(class=(title === 'Integrations' ? 'active' : ''))
a(href='/integrations/' + themeQs) Integrations
li.dropdown
a.dropdown-toggle(href='#', data-toggle='dropdown') Resources 
a.dropdown-toggle(href='#', data-toggle='dropdown') Resources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change didn't modify the display at all? I remember the   being required, but perhaps I'm wrong.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Normally it is; I just used | instead which we use elsewhere.

|
span.caret
ul.dropdown-menu.dropdown-menu-right(role='menu')
li
Expand Down
2 changes: 1 addition & 1 deletion views/layout.pug
View file
Open in desktop
Expand Up @@ -18,7 +18,7 @@ html(lang='en', prefix='og: http://ogp.me/ns#', itemscope, itemtype='http://sche

link(rel='dns-prefetch', href='//fonts.googleapis.com')

link(rel='apple-touch-icon', sizes='180x180', href=helpers.buster('/assets/img/favicons/apple-touch-icon.png'))
link(rel='apple-touch-icon', href=helpers.buster('/assets/img/favicons/apple-touch-icon.png'), sizes='180x180')
link(rel='icon', type='image/png', href=helpers.buster('/assets/img/favicons/favicon-32x32.png'), sizes='32x32')
link(rel='icon', type='image/png', href=helpers.buster('/assets/img/favicons/favicon-16x16.png'), sizes='16x16')
link(rel='manifest', href='/assets/img/favicons/manifest.json')
Expand Down