Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add latency flag #21

Merged
merged 11 commits into from
Feb 23, 2023
Merged

feat: add latency flag #21

merged 11 commits into from
Feb 23, 2023

Conversation

ayuhito
Copy link
Member

@ayuhito ayuhito commented Feb 23, 2023

Closes #8. Adds a new --latency flag to relevant commands as a method to quickly gather latency numbers.

Relevant screenshots:
Ping
image
DNS
image
HTTP
image

@ayuhito
Copy link
Member Author

ayuhito commented Feb 23, 2023

@jimaek, let me know if we should change how they look.

Regarding MTR, I was wondering whether you wanted to print out the individual stats for every hop? I'm not sure if that was your intention similar to traceroute.

@ayuhito ayuhito requested a review from jimaek February 23, 2023 07:00
@jimaek
Copy link
Member

jimaek commented Feb 23, 2023

Regarding MTR, I was wondering whether you wanted to print out the individual stats for every hop? I'm not sure if that was your intention similar to traceroute

Every hop makes no sense I think (JSON can be used for that), just total similar to the rest

@ayuhito
Copy link
Member Author

ayuhito commented Feb 23, 2023

Regarding MTR, I was wondering whether you wanted to print out the individual stats for every hop? I'm not sure if that was your intention similar to traceroute

Every hop makes no sense I think (JSON can be used for that), just total similar to the rest

My point is that there is no total stat. Stats are given per hop only.

@jimaek
Copy link
Member

jimaek commented Feb 23, 2023

Then no support for mtr then I think

@ayuhito ayuhito merged commit 212dc98 into master Feb 23, 2023
@ayuhito ayuhito deleted the feat/latency branch February 23, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Latency parameter
2 participants