Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add isp names and regions to header output #24

Merged
merged 3 commits into from
Feb 24, 2023
Merged

Conversation

ayuhito
Copy link
Member

@ayuhito ayuhito commented Feb 23, 2023

Closes #7. @jimaek, let me know if the output looks good before I merge this.

No tag
image

With tag
image
image

Will also make a corresponding PR for the Slack and Discord bots.

@ayuhito ayuhito requested a review from jimaek February 23, 2023 20:20
@jimaek
Copy link
Member

jimaek commented Feb 23, 2023

I think the region name should go in () to separate it from the rest since it's a special kind of field and directly applies to the ISP name

@ayuhito
Copy link
Member Author

ayuhito commented Feb 23, 2023

I think the region name should go in () to separate it from the rest since it's a special kind of field and directly applies to the ISP name

image
image

Sounds good to me.

@jimaek
Copy link
Member

jimaek commented Feb 23, 2023

LGTM

@ayuhito ayuhito merged commit 451cbc0 into master Feb 24, 2023
@ayuhito ayuhito deleted the feat/tag-headers branch February 24, 2023 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ISP name and Cloud regions to output
2 participants