Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SharepointPlus project #1002

Merged
merged 4 commits into from
Jun 25, 2014
Merged

Fix SharepointPlus project #1002

merged 4 commits into from
Jun 25, 2014

Conversation

Aymkdn
Copy link
Contributor

@Aymkdn Aymkdn commented Jun 23, 2014

No description provided.

@jsdelivrbot
Copy link
Contributor

It looks like you want to contribute to jsdelivr/jsdelivr, @Aymkdn, however there seems to be some issues with your pull request. See contributing for help ammending your PR...

  • There are some fundamental issues with your PR 🙅
    • You appear to be changing the file contents of sharepointplus.min.js in 3.0.9!

Thanks again for contributing.. If you think this review was wrong/unfair/etc. submit a bug on the bot's repo
It's not fully shipped until it's fast.

@megawac
Copy link

megawac commented Jun 23, 2014

How about creating a new tag instead of updating the file (that would be the semver complaint way). We really shouldn't change files once we start hosting them

@Aymkdn
Copy link
Contributor Author

Aymkdn commented Jun 24, 2014

I don't want to create a new tag. I want to update that file. Please accept my request, or delete the file. I don't want to keep an incorrectly compressed file.

@megawac
Copy link

megawac commented Jun 24, 2014

Speaking of tags, it looks like you didn't create a tag for v3.0.9. You're the author so I'm not too against accepting this, but I'll leave it up to @pnommensen

@Aymkdn
Copy link
Contributor Author

Aymkdn commented Jun 24, 2014

The 3.0.9 is already there : https://github.com/jsdelivr/jsdelivr/tree/master/files/sharepointplus/3.0.9

So I don't understand what you mean...

@megawac
Copy link

megawac commented Jun 24, 2014

@Aymkdn
Copy link
Contributor Author

Aymkdn commented Jun 24, 2014

Yes I wanted to make sure all is OK with jsdeliver first. But how is this related to jsdeliver ?! ....

megawac added a commit that referenced this pull request Jun 25, 2014
Fix SharepointPlus project
@Aymkdn next time release a new version please
@megawac megawac merged commit 44a3f86 into jsdelivr:master Jun 25, 2014
@Aymkdn
Copy link
Contributor Author

Aymkdn commented Jun 25, 2014

Merci 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants