Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submitting a concated and minified version of AngularJS with all extention modules included #1044

Closed
wants to merge 9 commits into from

Conversation

Todd-Werelius
Copy link
Contributor

No description provided.

@jsdelivrbot
Copy link
Contributor

It looks like you want to contribute to jsdelivr/jsdelivr, @Todd-Werelius, however there seems to be some issues with your pull request. See contributing for help ammending your PR...

  • Might be nothing but I have some concerns about the files in your submission...
    • Unescaped unicode characters in angular-all.min.js (at pos 41664)
    • Unescaped unicode characters in angular-all.min.js (at pos 42871)

Thanks again for contributing.. If you think this review was wrong/unfair/etc. submit a bug on the bot's repo
Favor focus over features.

@Todd-Werelius
Copy link
Contributor Author

These are uglified files, I can't see any issues with the flagged part of the files ( I think I am looking at the correct output )

s=function(t){return"function"==typeof t?t.toString().replace(/ {[\s\S]*$/,"")

of

a=arguments,s=function(t){return"function"==typeof t?t.toString().replace(/ {[\s\S]*$/,"")

Does not look suspicious to me

@jimaek
Copy link
Member

jimaek commented Jun 28, 2014

Looks good but can you please squash the commits into 1 single commit?

@Todd-Werelius
Copy link
Contributor Author

Yep

@Todd-Werelius
Copy link
Contributor Author

Ug I mucked this up with an upstream merge earlier, I don't see a way to easily solve this I will have to close this request and fix things on my end.

@megawac
Copy link

megawac commented Jun 28, 2014

git reset --soft HEAD~9
git commit -am "Update angular.js"
git push --force

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants