Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove E2D project #10695

Merged
merged 1 commit into from
Mar 30, 2016
Merged

Remove E2D project #10695

merged 1 commit into from
Mar 30, 2016

Conversation

jackdalton
Copy link
Contributor

I'm removing this so @jtenner can use the name for his neat project.

@jimaek
Copy link
Member

jimaek commented Mar 30, 2016

We cant just remove it. It will break the websites of people using these files

@megawac Why the bot marked this as LGTM? There should have been huge warnings about removing files

@jackdalton
Copy link
Contributor Author

I'm pretty sure no websites actually use these files.

On Wed, Mar 30, 2016, 4:41 AM Dmitriy Akulov notifications@github.com
wrote:

We cant just remove it. It will break the websites of people using these
files

@megawac https://github.com/megawac Why the bot marked this as LGTM?
There should have been huge warnings about removing files


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#10695 (comment)

@jimaek
Copy link
Member

jimaek commented Mar 30, 2016

How about creating a new folder called e2d.js instead?

@megawac
Copy link

megawac commented Mar 30, 2016

Not sure, mind making a bot issue linking this thread. I'll have time to look into stuff 2 weekends from now

@jackdalton
Copy link
Contributor Author

Sounds good to me but you should check with @jtenner, he may want something
different.

On Wed, Mar 30, 2016, 5:10 AM Dmitriy Akulov notifications@github.com
wrote:

How about creating a new folder called e2d.js instead?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#10695 (comment)

@megawac
Copy link

megawac commented Mar 30, 2016

Oh @jimaek it's because the bot only cares about deletions in <project>/<version folders. Not about deletions in <project> folders

@jimaek
Copy link
Member

jimaek commented Mar 30, 2016

I see, we should probably make it care for all kinds of deletions

@megawac
Copy link

megawac commented Mar 30, 2016

@jimaek why, its not going to merge this kind of pull request and its pretty clear to the person merging there is a project being deleted

@jimaek
Copy link
Member

jimaek commented Mar 30, 2016

Someone could add 20 new files to 1 project and then remove an other project. The mod could take a look at the bot's output that there are new files and everything else is good and merge.

@jtenner
Copy link
Contributor

jtenner commented Mar 30, 2016

Hello Everyone! Thank you for taking the time to help!

@megawac is right, because the project is being deleted. I need the e2d namespace. Nobody uses the other e2d library and it should be taken down.

I don't need anything special, and I'm also okay with using e2d.js as the jsdelivr namespace. It's just that it will be confusing to developers trying to use it.

@jimaek
Copy link
Member

jimaek commented Mar 30, 2016

It looks like you transferred the e2d organization to @jtenner, in this case we dont need to anything at all. We can keep all the old versions and then add the new versions.
Plus you can update the description file.
What do you guys think?

@jackdalton
Copy link
Contributor Author

I actually deleted the organization, it should be available to @jtenner if
he desires it.

On Wed, Mar 30, 2016, 1:45 PM Dmitriy Akulov notifications@github.com
wrote:

It looks like you transferred the e2d organization to @jtenner
https://github.com/jtenner, in this case we dont need to anything at
all. We can keep all the old versions and then add the new versions.
Plus you can update the description file.
What do you guys think?


You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub
#10695 (comment)

@jtenner
Copy link
Contributor

jtenner commented Mar 30, 2016

You guys misunderstand, @jimaek my e2d library has a different API and does different things. Keeping the old versions of @jackdalton 's library would confuse my users.

It's a completely different project. Sorry to be a bother.

@jimaek jimaek merged commit b1ad005 into jsdelivr:master Mar 30, 2016
@jimaek
Copy link
Member

jimaek commented Mar 30, 2016

@jtenner You can now submit your project like you would normally do.

@jtenner
Copy link
Contributor

jtenner commented Mar 30, 2016

Wonderful. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants