Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ open-iconic/update.json, needs opinion #2036

Closed
wants to merge 1 commit into from
Closed

+ open-iconic/update.json, needs opinion #2036

wants to merge 1 commit into from

Conversation

tomByrer
Copy link
Contributor

So seems the WebP images were uploaded, but not the far more browser-supported PNGs. 1300 images is quite a few but 1300_2_new version every 3-4 months is alot.

Maybe drop both until people ask for them? Really the thrust of Iconic is individual SVG images. The fonts & raster images are provided as a backup. No one complained that the PNGs were missing, even though they're required by IE8. (& IMHO SVG should be THE format for icons).

@somerandomdude this file is for automated uploads to the CDN.

So seems the [WebP](https://github.com/jsdelivr/jsdelivr/tree/master/files/open-iconic/1.1.0/webp) images were uploaded, but not the far more browser-supported [PNG](https://github.com/iconic/open-iconic/tree/master/png)s.  1300 images is alot but 1300*2*new version every 3-4 months is alot.
Maybe drop both until people ask for them?  Really the thrust of Iconic is individual SVG images.  The fonts & raster images are provided as a backup.  No one complained that the PNGs were missing, even though they're required by IE8.  (& IMHO SVG should be THE format for icons).
@somerandomdude this file is for automated uploads to the CDN.
@jimaek
Copy link
Member

jimaek commented Oct 18, 2014

I think thats too much. Using a custom setup would be better in this case

@tomByrer
Copy link
Contributor Author

Exactly what do you mean by "custom setup" please? The way I did it?

@jimaek
Copy link
Member

jimaek commented Oct 18, 2014

I mean a proxy setup or manually uploading to origin. Github is not the place to store so many images

@tomByrer
Copy link
Contributor Author

Github is not the place to store so many images

It's a good thing we're having this conversation; I almost sent a PR to upload 1000+ of Google's icons! (They are not cooked enough yet.)

Is there a semi-standardized way that you want to get these proxy requests please? I'm starting to want to host sets of SVG icons & other images; I think they're better than icon-fonts in many ways. I'm not too excited about PNG icons, but I suspect projects like Google's 'Material Design' will want to make their way into a CDN; lots of files, but standardized & likely used by many for years to come.

Would it be easier for you if there was a seperate repo with instructions in the README & Issues for submit proxy requests? (No PRs except for docs, unless you want to set up project.proxy.config files there.)

@tomByrer
Copy link
Contributor Author

For THIS project, upload only fonts only, or do you want to just proxy everything?

@jimaek
Copy link
Member

jimaek commented Oct 19, 2014

Proxy requests need to be configured by me on the origin so there are no instructions. Someone just needs to request the project and provide an origin to proxy cache.

For this repo I think it makes sense to proxy everything

@jimaek jimaek closed this Oct 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants