Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update project semantic-ui to 1.10.2 #3592

Merged
merged 1 commit into from
Feb 24, 2015
Merged

Update project semantic-ui to 1.10.2 #3592

merged 1 commit into from
Feb 24, 2015

Conversation

jsdelivrbot
Copy link
Contributor

libgrabber updated project semantic-ui to 1.10.2.

@Semantic-Org

Metadata information

{
  "metadata": {
    "packageManager": "github",
    "name": "semantic-ui",
    "repo": "Semantic-Org/Semantic-UI",
    "files": {
      "basePath": "dist/",
      "include": ["./components/**/*.min.*", "./themes/**/*", "semantic.min.css", "semantic.min.js"],
      "exclude": []
    },
    "path": "/home/jsdelivr/files/semantic-ui",
    "localVersions": ["0.15.1", "0.15.2", "0.16.1", "0.17.0", "0.18.0", "0.19.0", "0.19.1", "0.19.2", "0.19.3", "1.0.0", "1.0.1", "1.1.0", "1.1.1", "1.1.2", "1.2.0", "1.3.0", "1.3.1", "1.3.2", "1.4.0", "1.4.1", "1.5.0", "1.5.1", "1.5.2", "1.6.1", "1.6.2", "1.6.4", "1.7.0", "1.7.1", "1.7.2", "1.7.3", "1.8.0", "1.8.1", "1.9.0", "1.9.1", "1.9.2", "1.9.3", "1.10.0"],
    "remoteVersions": ["0.2.1", "0.2.2", "0.2.3", "0.2.4", "0.2.5", "0.3.0", "0.3.1", "0.3.2", "0.3.3", "0.3.4", "0.3.6", "0.3.7", "0.3.8", "0.4.2", "0.4.3", "0.5.0", "0.5.1", "0.6.0", "0.6.1", "0.6.2", "0.6.3", "0.6.4", "0.6.5", "0.7.0", "0.7.1", "0.7.2", "0.8.0", "0.8.1", "0.8.2", "0.8.3", "0.8.4", "0.8.5", "0.8.6", "0.9.0", "0.9.1", "0.9.2", "0.9.3", "0.9.4", "0.9.5", "0.9.6", "0.10.0", "0.10.1", "0.10.2", "0.10.3", "0.11.0", "0.12.0", "0.12.1", "0.12.2", "0.12.3", "0.12.4", "0.12.5", "0.13.0", "0.13.1", "0.14.0", "0.15.0", "0.15.1", "0.15.2", "0.15.3", "0.15.4", "0.15.5", "0.16.0", "0.16.1", "0.17.0", "0.18.0", "0.19.0", "0.19.1", "0.19.2", "0.19.3", "1.0.0-beta", "1.0.0", "1.0.1", "1.1.0", "1.1.1", "1.1.2", "1.2.0", "1.3.0", "1.3.1", "1.3.2", "1.4.0", "1.4.1", "1.5.0", "1.5.1", "1.5.2", "1.6.0", "1.6.1", "1.6.2", "1.6.3", "1.6.4", "1.7.0", "1.7.1", "1.7.2", "1.7.3", "1.8.0", "1.8.1", "1.9.0", "1.9.1", "1.9.2", "1.9.3", "1.10.0", "1.10.2"],
    "branchVersions": []
  },
  "version": "1.10.2",
  "updated": true,
  "updatePath": "/home/jsdelivr/files/semantic-ui/1.10.2",
  "branch": "semantic-ui/1.10.2"
}

@jsdelivrbot
Copy link
Contributor Author

It looks like you want to contribute to jsdelivr/jsdelivr, @jsdelivrbot, however there seems to be some issues with your pull request. See contributing for help amending your PR...

  • Looks like the info.ini has a few problems

    • Where is the semantic-ui's mainfile (semantic.min.js) in v-0.15.1
    • Where is the semantic-ui's mainfile (semantic.min.js) in v-0.15.2
    • Where is the semantic-ui's mainfile (semantic.min.js) in v-0.16.1
    • Where is the semantic-ui's mainfile (semantic.min.js) in v-0.17.0
    • Where is the semantic-ui's mainfile (semantic.min.js) in v-0.18.0
    • Where is the semantic-ui's mainfile (semantic.min.js) in v-0.19.0
    • Where is the semantic-ui's mainfile (semantic.min.js) in v-0.19.1
    • Where is the semantic-ui's mainfile (semantic.min.js) in v-0.19.2
    • Where is the semantic-ui's mainfile (semantic.min.js) in v-0.19.3
  • Might be nothing but I have some concerns about the files in your submission...

    • .woff2 (on themes/default/assets/fonts/icons.woff2) seems odd to want to host?
  • We try to keep the file structure as consistent as possible between versions; there were some changes in file structure from previous versions...

    • In semantic-ui between 1.8.1 and 1.10.2 there was a change in file structure
    + themes/default/assets/fonts/icons.woff2

Thanks again for contributing.. If you think this review was wrong/unfair/etc. submit a bug on the bot's repo
Design for failure.

megawac added a commit that referenced this pull request Feb 24, 2015
Update project semantic-ui to 1.10.2
@megawac megawac merged commit bbf480c into jsdelivr:master Feb 24, 2015
@megawac
Copy link

megawac commented Feb 24, 2015

Hey @jimaek what happened #3591

@jimaek jimaek deleted the semantic-ui/1.10.2 branch February 25, 2015 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants