Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mithril v0.1.11 - version upgrade #744

Merged
merged 1 commit into from
May 3, 2014
Merged

Conversation

lhorie
Copy link

@lhorie lhorie commented May 3, 2014

@jsdelivrbot
Copy link
Contributor

It looks like you want to contribute to jsdelivr/jsdelivr, @lhorie, however there seems to be some issues with your pull request. See contributing for help ammending your PR...

  • Might be nothing but I have some concerns about the files in your submission...

    • Expression document\.write had a match in the contents of mithril.js (0.1.11).
    • Expression document\.write had a match in the contents of mithril.min.js (0.1.11).
  • We try to keep the file structure as consistent as possible between versions; there were some changes in file structure from previous versions...

    • In mithril between 0.1.0 and 0.1.11 there was a change in file structure
    + mithril.js

Thanks again for contributing.. If you think this review was wrong/unfair/etc. submit a bug on the bot's repo
Responsive is better than fast.

@pnommensen
Copy link
Contributor

The second point is b/c v 0.1.0 and 0.1.1 doesn't include mithril.js. You don't need to worry about that for this merge. https://github.com/jsdelivr/jsdelivr/tree/master/files/mithril/0.1.0
https://github.com/jsdelivr/jsdelivr/tree/master/files/mithril/0.1.1

The first point, not sure -- @megawac? The Bot is still new and being changed all the time. Let's wait and find out and then I will merge this, thanks!

@megawac
Copy link

megawac commented May 3, 2014

its fine @pnommensen, he's the author of Mithrill anyway. Bots buggy since last night, haven't had any time to fix it today

pnommensen added a commit that referenced this pull request May 3, 2014
Mithril v0.1.11 - version upgrade
@pnommensen pnommensen merged commit 3b88fea into jsdelivr:master May 3, 2014
@pnommensen
Copy link
Contributor

Thanks @lhorie and @megawac :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants