Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hammer.js 1.1.2 #773

Merged
merged 1 commit into from
May 9, 2014
Merged

Add Hammer.js 1.1.2 #773

merged 1 commit into from
May 9, 2014

Conversation

gavinhungry
Copy link
Contributor

GitHub: https://github.com/EightMedia/hammer.js/tree/1.1.2

Including the non-minified JS as well because the previous version (1.0.7) did.

@jsdelivrbot
Copy link
Contributor

It looks like you want to contribute to jsdelivr/jsdelivr, @gavinhungry, however there seems to be some issues with your pull request. See contributing for help ammending your PR...

  • Looks like the info.ini has a few problems
    • Where is the hammerjs's mainfile (hammer.min.js) in v-0.6.4

Thanks again for contributing.. If you think this review was wrong/unfair/etc. submit a bug on the bot's repo
Mind your words, they are important.

pnommensen added a commit that referenced this pull request May 9, 2014
@pnommensen pnommensen merged commit 1dbdf09 into jsdelivr:master May 9, 2014
@pnommensen
Copy link
Contributor

Thanks @gavinhungry :)

Also pinging @jimaek because we have the same library in /files/hammer.js and /files/jquery.hammerjs. The later was probably merged by accident but should we now maintain complete versions in both directories?

@gavinhungry
Copy link
Contributor Author

@pnommensen, I didn't check the file contents of jquery.hammerjs (because I'm on my phone and holding a sleeping baby :), but looking just at the filenames it seems that library is just the Hammer.js jQuery plugin, while this commit is the standalone module.

The developer had them together at one point, but later separated them into different repos:

https://github.com/EightMedia/hammer.js
https://github.com/EightMedia/jquery.hammer.js

@pnommensen
Copy link
Contributor

@gavinhungry yup your right, thanks! wasn't expecting that and also didn't look. Just added latest version of jquery.hammerjs too #775

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants