-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add update.json file on threejs, enchantjs and pixijs projects #915
Conversation
"name": "pixijs", | ||
"repo": "GoodBoyDigital/pixi.js", | ||
"files": { | ||
"basePath": ["bin/"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can basepath be an array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whoops, fixed! thanks @megawac
@jimaek will non-semver versions work with the bot? |
They should but not 100%. We can try |
@ellisonleao |
Hm, i see, the file on the repo does not match the min file on the jsdelivr. Is this a problem. The minified file is called |
The structure of files between versions must remain same. We could switch to |
Oh now i see that the |
We can but are you 100% sure this the correct file to use in production? |
Yes! |
No we do not modify existing files. I am just thinking if the best solution here is to keep pixi manually updated. jsDelivr was manually updated all this time and not all projects support auto-update. |
I see, if you want i can remove it for now and we can only merge the threejs and the enchantjs files. Is that ok? |
I'm against removing files between patch releases. Personally I tend to rely on |
I meant to remove the pixi.js commit for now @megawac |
Alright sounds good. It'd be nice if the bot supported a hash mapping of files e.g. +{
+ "files": {
+ "basePath": "bin/",
+ "include": ["pixi.js"],
+ "map": {
+ "pixi.min.js": "bin/pixi.js"
+ }
+ }
+} |
I created the rename files feature idea in libgrabber's repo. |
Sure i've removed the pixijs entry for now. |
Can you rebase please? 1 commit for all files is enough. |
add update.json file on enchantjs project add update.json file on threejs project fix pixijs basepath update.json file Remove enchant.js file from include on update.json Remove pixijs update.json file
Sure! i've now squashed the commits into a single one. Is everything ok now? @jimaek |
Add update.json file on threejs, enchantjs and pixijs projects
Awesome, thank you :) |
No description provided.