Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update.json file on threejs, enchantjs and pixijs projects #915

Merged
merged 1 commit into from
Jun 9, 2014
Merged

Add update.json file on threejs, enchantjs and pixijs projects #915

merged 1 commit into from
Jun 9, 2014

Conversation

ellisonleao
Copy link
Contributor

No description provided.

"name": "pixijs",
"repo": "GoodBoyDigital/pixi.js",
"files": {
"basePath": ["bin/"],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can basepath be an array?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops, fixed! thanks @megawac

@megawac
Copy link

megawac commented Jun 9, 2014

@jimaek will non-semver versions work with the bot?

https://github.com/mrdoob/three.js/releases

@jimaek
Copy link
Member

jimaek commented Jun 9, 2014

They should but not 100%. We can try

@jimaek
Copy link
Member

jimaek commented Jun 9, 2014

@ellisonleao pixi.js wont work. bin/ does not contain the min file we host.

@ellisonleao
Copy link
Contributor Author

Hm, i see, the file on the repo does not match the min file on the jsdelivr. Is this a problem. The minified file is called pixi.dev.js . Should i include this file instead @jimaek ?

https://github.com/GoodBoyDigital/pixi.js/tree/master/bin/

@jimaek
Copy link
Member

jimaek commented Jun 9, 2014

The structure of files between versions must remain same. We could switch to pixi.dev.js but I dont think we should host it. It sounds that it was not intended for production.

@ellisonleao
Copy link
Contributor Author

Oh now i see that the pixi.js is the minified version. Can we switch to it? I can rename the info.ini file as well @jimaek

@jimaek
Copy link
Member

jimaek commented Jun 9, 2014

We can but are you 100% sure this the correct file to use in production?

@ellisonleao
Copy link
Contributor Author

Yes!
Another question: Should i rename the current pixi.min.js files that already exists?

@jimaek
Copy link
Member

jimaek commented Jun 9, 2014

No we do not modify existing files. I am just thinking if the best solution here is to keep pixi manually updated. jsDelivr was manually updated all this time and not all projects support auto-update.
pixi can be one of the projects that dont support it.

@ellisonleao
Copy link
Contributor Author

I see, if you want i can remove it for now and we can only merge the threejs and the enchantjs files. Is that ok?

@megawac
Copy link

megawac commented Jun 9, 2014

I'm against removing files between patch releases. Personally I tend to rely on @major.minor(file). Can we wait for the next minor release to make this change

E.g.
http://cdn.jsdelivr.net/pixi.js/1.5/pixi.min.js

@ellisonleao
Copy link
Contributor Author

I meant to remove the pixi.js commit for now @megawac

@megawac
Copy link

megawac commented Jun 9, 2014

Alright sounds good. It'd be nice if the bot supported a hash mapping of files e.g.

+{
+  "files": {
+    "basePath": "bin/",
+    "include": ["pixi.js"],
+    "map": {
+        "pixi.min.js": "bin/pixi.js"
+    }
+  }
+}

@jimaek
Copy link
Member

jimaek commented Jun 9, 2014

I created the rename files feature idea in libgrabber's repo.
I think until its decided we should not enable pixi.js.

@ellisonleao
Copy link
Contributor Author

Sure i've removed the pixijs entry for now.

@jimaek
Copy link
Member

jimaek commented Jun 9, 2014

Can you rebase please? 1 commit for all files is enough.

add update.json file on enchantjs project

add update.json file on threejs project

fix pixijs basepath update.json file

Remove enchant.js file from include on update.json

Remove pixijs update.json file
@ellisonleao
Copy link
Contributor Author

Sure! i've now squashed the commits into a single one. Is everything ok now? @jimaek

jimaek added a commit that referenced this pull request Jun 9, 2014
Add update.json file on threejs, enchantjs and pixijs projects
@jimaek jimaek merged commit 347ac9e into jsdelivr:master Jun 9, 2014
@jimaek
Copy link
Member

jimaek commented Jun 9, 2014

Awesome, thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants