Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recheck image sizes #406

Closed
MartinKolarik opened this issue Sep 2, 2021 · 5 comments · Fixed by #407
Closed

Recheck image sizes #406

MartinKolarik opened this issue Sep 2, 2021 · 5 comments · Fixed by #407
Assignees
@xbpcb
Labels
high priority

Comments

@MartinKolarik
Copy link
Member

After #351 we've got wrong dimensions set in some places. I noticed and fixed one in 4ba9170, now noticed another one at https://www.jsdelivr.com/esm (our logo looks bad). @xbpcb please recheck all images in all places and fix the ones that are wrong.
@xbpcb
Copy link
Collaborator

xbpcb commented Sep 4, 2021

I am not sure about this 4ba9170
The correct width of google logo is 154px
Check it:
2021-09-04_14-11
2021-09-04_14-12

@xbpcb xbpcb mentioned this issue Sep 4, 2021
Merged
@MartinKolarik
Copy link
Member Author

I see the problem now - we don't have the same aspect ratios for the regular and @2x version. You set the dimensions for the regular version and it looked broken when I got the @2x version displayed.

So need to check and fix the images - Google, our logo on these pages, and anything else that you find.

@MartinKolarik
Copy link
Member Author

Another thing that has a wrong size is the hits badge at https://www.jsdelivr.com/package/npm/bootstrap - the width can't be set as it changes depending on the content.

@MartinKolarik
Copy link
Member Author

@xbpcb please prioritize this issue.

@xbpcb
Copy link
Collaborator

xbpcb commented Sep 10, 2021

@MartinKolarik got it

xbpcb added a commit that referenced this issue Sep 14, 2021
@xbpcb
Merge branch 'master' into gh-406
f85b9e2
@tjenkinson tjenkinson mentioned this issue Feb 2, 2024
Open
@tjenkinson tjenkinson mentioned this issue May 14, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xbpcb xbpcb

Labels
high priority
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Gh 406 jsdelivr/www.jsdelivr.com
2 participants
@MartinKolarik @xbpcb