Add Lazyload attribute to images #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
jimaek
reviewed
Mar 23, 2021
| @@ -1,5 +1,5 @@ | |||
| <div class="c-infographic-banner"> | |||
| <img src="{{@shared.assetsHost}}/img/landing/infographic-bg.png" srcset="{{@shared.assetsHost}}/img/landing/infographic-bg@2x.png 2x"> | |||
| <img src="{{@shared.assetsHost}}/img/landing/infographic-bg.png" srcset="{{@shared.assetsHost}}/img/landing/infographic-bg@2x.png 2x" loading="lazy"> | |||
There was a problem hiding this comment.
For anything above the fold I dont think there is a point to do lazy loading. Here the whole point of the page is the image, so lazyloading would make a bad user experience. Please remove it
There was a problem hiding this comment.
Done, let me know if there are any other images you want me to revert :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #355, I have added lazy load attributes to images not in the initial viewport to help increase site performance.
I had some acceptance tests fail but I think it was due to issues with pages not loading quickly enough on my PC.
This is my first pull request so let me know if it's all OK.