-
-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign #400
Redesign #400
Conversation
Your Render PR Server URL is https://www-jsdelivr-com-pr-400.onrender.com. Follow its progress at https://dashboard.render.com/web/srv-c3omq3s6fj33so8vcgr0. |
Please pull in the latest commits from master to fix the PR preview. |
moved below |
History page: Done:
|
moved below |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Package page: https://www-jsdelivr-com-pr-400.onrender.com/package/npm/react
|
Footer:
|
I updated my to-do comments above with some new tasks. |
Repost of my previous comments because GitHub now hides them Purge page: done:
probably expand on click anywhere and don't change border, make sure the cursor indicates the area is clickable
see https://www.jsdelivr.com/tools/purge, in CSS it was previously implemented by the wrapper/push elements |
Homepage:
Done:
|
Please also check this on all pages: #400 (comment) |
@itstarlight0808 yes, fixed position for each button type, empty space when it's missing. |
@MartinKolarik
|
@itstarlight0808 it'll use data from 2.1, updated doc and mocks here: |
I already got it , but can't notice its usage. But it doesn't work. :( |
@itstarlight0808 that's exactly how the URL will be but it isn't live yet, that's why you have sample data files there. You can create all functions as needed (including the URL construction logic) but instead of making real http calls just return data from that zip (copy paste the data into the JS as needed and when the API is live we'll just remove it and make real http calls). |
So for those two tables, render data from |
Update copy to clipboard tooltip style to match the rest
WIP: Fix Homepage bugs: part 4
WIP: Third-party images and badges in readmes
Redesign jsDelivr