Update libs "clipboard" and "marked" #401
Conversation
src/views/pages/network.html
Outdated
| @@ -21,22 +21,6 @@ | |||
| {{/each}} | |||
| </style> | |||
|
|
|||
| {{#if !@shared.isServer && !@shared.googleMapsLoaded}} | |||
There was a problem hiding this comment.
There's no difference here, the scripts are already dynamically inserted and therefore async. Please revert this part.
There was a problem hiding this comment.
Done! Out of curiosity where is the dynamic insertion happening from?
There was a problem hiding this comment.
The whole file is a Ractive component so the rendering is handled by Ractive and this section is specifically restricted from server rendering (!@shared.isServer) so it happens on the client.
There was a problem hiding this comment.
Thank you! I'll look into how Mustaches is used, I haven't come across it before
MartinKolarik
changed the title
src/views/pages/network.html
Outdated
| @@ -109,10 +109,10 @@ <h3>Big network in China</h3> | |||
|
|
|||
| <div class="china-banner"> | |||
| <div class="china-bg"> | |||
| <img width="1140" height="328" src="{{@shared.assetsHost}}/img/network/china-bg.jpg" srcset="{{@shared.assetsHost}}/img/network/china-bg@2x.jpg 2x" loading="lazy"> | |||
There was a problem hiding this comment.
This seems to be a mistake?
There was a problem hiding this comment.
Did one too many ctrl+z, reverted :)
|
Looks good now 👍 |
Three small changes which contribute towards optimizations listed in #331