Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dropping = prefix (optional type indicator) #121

Closed
brettz9 opened this issue Jul 6, 2020 · 1 comment · Fixed by #124
Closed

Dropping = prefix (optional type indicator) #121

brettz9 opened this issue Jul 6, 2020 · 1 comment · Fixed by #124
Labels
missing-support

Comments

@brettz9
Copy link
Contributor

brettz9 commented Jul 6, 2020 •
edited

There is the PrefixOptionalTypeExpr which indicates as an example =string (while mentioning it is deprecated--the suffixed version is not), but I don't see this in catharsis or mention of it in Closure docs, so it seems that one should be dropped from jsdoctypeparser entirely now, unless TS is using it. (If TS is using it, we could still handle it in check-syntax in eslint-plugin-jsdoc for the other modes.)
brettz9 added a commit to brettz9/jsdoctypeparser that referenced this issue Jul 9, 2020
@brettz9
feat: remove deprecated PrefixOptionalTypeExpr rule; fixes jsdoctyp…
1d7bc23 
…eparser#121

BREAKING CHANGE:

Removes `=string` type syntax
@brettz9 brettz9 mentioned this issue Jul 9, 2020
Merged
@sandersn
Copy link
Contributor

sandersn commented Jul 9, 2020

Nope, this is not supported in Typescript either.

brettz9 added a commit that referenced this issue Jul 9, 2020
@brettz9
feat: remove deprecated PrefixOptionalTypeExpr rule; fixes #121
4dec957 
BREAKING CHANGE:

Removes `=string` type syntax
brettz9 added a commit to brettz9/jsdoctypeparser that referenced this issue Jul 9, 2020
@brettz9
fix: trigger for semantic-release; fixes jsdoctypeparser#121
b2ea812
brettz9 added a commit to brettz9/jsdoctypeparser that referenced this issue Jul 9, 2020
@brettz9
feat: trigger for semantic-release; fixes jsdoctypeparser#121
d17e2bc
brettz9 added a commit to brettz9/jsdoctypeparser that referenced this issue Jul 9, 2020
@brettz9
feat: trigger for semantic-release; removed deprecated `PrefixOptio…
a1b508a 
…nalTypeExpr` rule; fixes jsdoctypeparser#121

BREAKING CHANGE:

Removes `=string` type syntax
brettz9 added a commit to brettz9/jsdoctypeparser that referenced this issue Jul 9, 2020
@brettz9
feat: trigger for semantic-release; removed deprecated `PrefixOptio…
314b91d 
…nalTypeExpr` rule; fixes jsdoctypeparser#121

BREAKING CHANGE:

Removes `=string` type syntax
brettz9 added a commit to brettz9/jsdoctypeparser that referenced this issue Jul 9, 2020
@brettz9
feat: trigger for semantic-release; removed deprecated `PrefixOptio…
f505e15 
…nalTypeExpr` rule; fixes jsdoctypeparser#121

BREAKING CHANGE:

Removes `=string` type syntax
brettz9 added a commit to brettz9/jsdoctypeparser that referenced this issue Jul 9, 2020
@brettz9
feat: trigger for semantic-release; removed deprecated `PrefixOptio…
adf5f0e 
…nalTypeExpr` rule; fixes jsdoctypeparser#121

BREAKING CHANGE:

Removes `=string` type syntax
brettz9 added a commit to brettz9/jsdoctypeparser that referenced this issue Jul 9, 2020
@brettz9
feat: trigger for semantic-release; removed deprecated `PrefixOptio…
c7cc13c 
…nalTypeExpr` rule; fixes jsdoctypeparser#121

BREAKING CHANGE:

Removes `=string` type syntax
brettz9 added a commit to brettz9/jsdoctypeparser that referenced this issue Jul 9, 2020
@brettz9
feat: trigger for semantic-release; removed deprecated `PrefixOptio…
76a8608 
…nalTypeExpr` rule; fixes jsdoctypeparser#121

BREAKING CHANGE:

Removes `=string` type syntax
brettz9 added a commit to brettz9/jsdoctypeparser that referenced this issue Jul 9, 2020
@brettz9
feat: trigger for semantic-release; removed deprecated `PrefixOptio…
f13cb5e 
…nalTypeExpr` rule; fixes jsdoctypeparser#121

BREAKING CHANGE:

Removes `=string` type syntax
brettz9 added a commit to brettz9/jsdoctypeparser that referenced this issue Jul 9, 2020
@brettz9
feat: trigger for semantic-release; removed deprecated `PrefixOptio…
e8754c4 
…nalTypeExpr` rule; fixes jsdoctypeparser#121

BREAKING CHANGE:

Removes `=string` type syntax
brettz9 added a commit to brettz9/jsdoctypeparser that referenced this issue Apr 21, 2021
@brettz9
feat: trigger for semantic-release; removed deprecated `PrefixOptio…
5fa673a 
…nalTypeExpr` rule; fixes jsdoctypeparser#121

BREAKING CHANGE:

Removes `=string` type syntax
brettz9 added a commit to brettz9/jsdoctypeparser that referenced this issue Apr 24, 2021
@brettz9
feat: trigger for semantic-release; removed deprecated `PrefixOptio…
a20924e 
…nalTypeExpr` rule; fixes jsdoctypeparser#121

BREAKING CHANGE:

Removes `=string` type syntax
sandersn pushed a commit that referenced this issue Apr 26, 2021
@brettz9
GH Actions (#137)
2204e85 
* feat: trigger for `semantic-release`; removed deprecated `PrefixOptionalTypeExpr` rule; fixes #121

BREAKING CHANGE:

Removes `=string` type syntax

* - Add for CI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
missing-support
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove deprecated PrefixOptionalTypeExpr brettz9/jsdoctypeparser
2 participants
@brettz9 @sandersn