Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export mode-specific SyntaxError's #120

Merged
merged 1 commit into from Jul 6, 2020
Merged

Export mode-specific SyntaxError's #120

merged 1 commit into from Jul 6, 2020

Conversation

brettz9
Copy link
Contributor

@brettz9 brettz9 commented Jul 5, 2020 •
edited

Realized our demo will need these...

(This is probably more of a bug for missing these in the exports than a feature, but it wasn't exactly broken either.)

@brettz9 brettz9 requested a review from sandersn July 5, 2020 03:53
sandersn
sandersn approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a [minor version] publish too?

@brettz9 brettz9 merged commit aca6e65 into jsdoctypeparser:master Jul 6, 2020
@brettz9
Copy link
Contributor Author

brettz9 commented Jul 6, 2020

Yes, I think our demo should probably point to a properly versioned file. However, I will see about getting semantic-release ready to the extent I can, if that's all right. Even if updates ended up frequent, I think it is handy for people to have versioned access to the fixes or improvements.

@brettz9 brettz9 deleted the mode-specific-errors branch July 6, 2020 23:50
@brettz9
Copy link
Contributor Author

brettz9 commented Jul 10, 2020 •
edited

FWIW, I've updated https://jsdoctypeparser.github.io/ to incorporate that release with the new feature to be able to change mode and/or startRule

Should maybe in future explicitly export a complete list of start rules (if not modes) so the UI can instead be built dynamically. JSON Schemas might be ideal for this as, unlike constants, their title/description can be leveraged for human-readable text (and may fit in with #77 also). (Filed #125 )

@brettz9 brettz9 mentioned this pull request Jul 10, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandersn sandersn sandersn approved these changes

Assignees
No one assigned
Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brettz9 @sandersn