Fix crash when calling window.close() inside load event listener

See whatwg/streams#1189 (comment) for context.
jsdom · Dec 2, 2021 · e46f76f · e46f76f
1 parent f9de3fd
commit e46f76f
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/lib/jsdom/browser/Window.js b/lib/jsdom/browser/Window.js
@@ -910,6 +910,9 @@ function Window(options) {
     } else {
       window.document.addEventListener("load", () => {
         fireAnEvent("load", window, undefined, {}, true);
+        if (!window._document) {
+          return; // window might've been closed already
+        }
 
         const documentImpl = idlUtils.implForWrapper(window._document);
         if (!documentImpl._pageShowingFlag) {

diff --git a/test/api/from-outside.js b/test/api/from-outside.js
@@ -3,7 +3,7 @@ const path = require("path");
 const { spawnSync } = require("child_process");
 const { assert } = require("chai");
 const { describe, it } = require("mocha-sugar-free");
-const { JSDOM } = require("../..");
+const { JSDOM, VirtualConsole } = require("../..");
 const { delay } = require("../util");
 
 describe("Test cases only possible to test from the outside", () => {
@@ -52,4 +52,20 @@ describe("Test cases only possible to test from the outside", () => {
     const diffInMB = diffInBytes / 1024 / 1024;
     assert.isBelow(diffInMB, 5);
   });
+
+  it("window.close() should work from within a load event listener", async () => {
+    const errors = [];
+    const virtualConsole = new VirtualConsole().sendTo(console);
+    virtualConsole.on("jsdomError", e => {
+      errors.push(e);
+    });
+
+    const { window } = new JSDOM(``, { virtualConsole });
+    window.addEventListener("load", () => {
+      window.close();
+    });
+    await delay(0);
+
+    assert.isEmpty(errors);
+  });
 });