Update Node.js minimum and dependencies; remove running-in-a-browser support #3542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that we can't yet test in Node v20 (or v19) due to nodejs/node#47798.
domenic
force-pushed
the
node16-plus
branch
2 times, most recently
from
cfe472d
to
6ae50a1
Compare
This is not worth maintaining at this point: * Maintainer bandwidth is at a historical low. * Very few people use Browserify these days (as opposed to Webpack or ESBuild). * Karma is deprecated, so our testing solution is going to be hard to maintain. * Web platform tests have never run in the browser so much of our coverage is missing. * Having a more complex testing solution makes improvements to testing harder. Closes #2892.
domenic
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that we can't yet test in Node v20 (or v19) due to nodejs/node#47798.