Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Node.js minimum and dependencies; remove running-in-a-browser support #3542

Merged
merged 3 commits into from
May 2, 2023
Merged

Update Node.js minimum and dependencies; remove running-in-a-browser support #3542

merged 3 commits into from
May 2, 2023

Commits on May 1, 2023

  1. Update Node.js minimum and dependencies 

    Note that we can't yet test in Node v20 (or v19) due to nodejs/node#47798.
    @domenic
    domenic committed May 1, 2023
    Configuration menu
    Copy the full SHA
    ee7957a View commit details
    Browse the repository at this point in the history

  2. Update CI to run on latest Ubuntu

    @domenic
    domenic committed May 1, 2023
    Configuration menu
    Copy the full SHA
    97122b4 View commit details
    Browse the repository at this point in the history

  3. Remove support for running jsdom in a browser 

    This is not worth maintaining at this point:

* Maintainer bandwidth is at a historical low.

* Very few people use Browserify these days (as opposed to Webpack or ESBuild).

* Karma is deprecated, so our testing solution is going to be hard to maintain.

* Web platform tests have never run in the browser so much of our coverage is missing.

* Having a more complex testing solution makes improvements to testing harder.

Closes #2892.
    @domenic
    domenic committed May 1, 2023
    Configuration menu
    Copy the full SHA
    148368e View commit details
    Browse the repository at this point in the history