Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add storybook? styleguide and plan component development #65

Closed
pixelmord opened this issue Mar 31, 2018 · 4 comments
Closed

Add storybook? styleguide and plan component development #65

pixelmord opened this issue Mar 31, 2018 · 4 comments
Assignees

Comments

@pixelmord
Copy link

I saw that issue #7 mentions the "bonus" of a storybook story for the permissions page and #17 deals with components that are Drupal Admin specific.

I think it would be a good idea to

  1. have a storybook style guide for this project to enable style development asynchronously to feature implementation
  2. to create an architecture where we do not copy paste components between react-drupal-components and this project, but for example, require drupal-react-components as a dependency lib.

Then we can decide if a component like the Message component should also go to the more general Drupal components in the drupal-react-components project, where people with a Drupal background could use them for all kinds of React projects.

I think that would make a sustainable solution that would only need a bit of refactoring in the already existing components to make them compatible with emotion or other concepts of providing styles through passing in className as a prop.

@dawehner
Copy link
Contributor

I agree we should copy over the work we did on the components branch over here: https://github.com/jsdrupal/drupal-react-components

@justafish justafish self-assigned this Mar 31, 2018
@pixelmord
Copy link
Author

@dawehner I do not understand completely what you mean?
I was proposing to let the jsdrupal/drupal-react-components project continue and require it as a dependency by jsdrupal/drupal-admin-ui so the latter can be concerned with functional components and the presentational stuff can be developed in the former project.

In the drupal-react-components we might want to refactor a bit to make it compatible with both classNames provided as plain strings and ones generated by emotion...

However, I can also understand when we do not want to go multi-repo from the get-go...

@justafish
Copy link
Contributor

We discussed this a few meetings ago, but we'll probably go the route of yarn workspaces, but for now just trying to keep things relatively simple whilst we get our feet off the ground

justafish added a commit that referenced this issue Jul 9, 2018
@dawehner
Copy link
Contributor

We've added storybook; yeah!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants