New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add storybook? styleguide and plan component development #65
Comments
I agree we should copy over the work we did on the components branch over here: https://github.com/jsdrupal/drupal-react-components |
@dawehner I do not understand completely what you mean? In the drupal-react-components we might want to refactor a bit to make it compatible with both classNames provided as plain strings and ones generated by emotion... However, I can also understand when we do not want to go multi-repo from the get-go... |
We discussed this a few meetings ago, but we'll probably go the route of yarn workspaces, but for now just trying to keep things relatively simple whilst we get our feet off the ground |
We've added storybook; yeah! |
I saw that issue #7 mentions the "bonus" of a storybook story for the permissions page and #17 deals with components that are Drupal Admin specific.
I think it would be a good idea to
Then we can decide if a component like the
Message
component should also go to the more general Drupal components in the drupal-react-components project, where people with a Drupal background could use them for all kinds of React projects.I think that would make a sustainable solution that would only need a bit of refactoring in the already existing components to make them compatible with emotion or other concepts of providing styles through passing in className as a prop.
The text was updated successfully, but these errors were encountered: