-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StepQueryWithIterator could pass ticket to interested methods #6
Comments
Yes it would be probably a better design. |
mscappini
pushed a commit
to mscappini/quickbooks-sync
that referenced
this issue
Sep 27, 2015
… ticket to SaveMessage and RetrieveMessage.
mscappini
pushed a commit
to mscappini/quickbooks-sync
that referenced
this issue
Sep 27, 2015
… ticket to SaveMessage and RetrieveMessage.
mscappini
pushed a commit
to mscappini/quickbooks-sync
that referenced
this issue
Sep 27, 2015
… ticket to SaveMessage and RetrieveMessage.
mscappini
pushed a commit
to mscappini/quickbooks-sync
that referenced
this issue
Sep 27, 2015
… ticket to SaveMessage and RetrieveMessage.
Big log here because I keep overwriting the commit to get the right commit message to close the related issue. Never done that before, super cool! |
jsgoupil
added a commit
that referenced
this issue
Nov 3, 2015
Fixes #6: StepQueryWithIterator now passes the authentication ticket to SaveMessage and RetrieveMessage.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I think the
StepQueryWithIterator
class could pass theauthenticatedTicket
to theSaveMessage
andRetrieveMessage
methods in lieu of the currentticket
andstep
. This would be useful because (in my implementation, for example) the ticket I use inherits from theAuthenticatedTicket
class and is tracked in memory while storing a state (associated with the ticket) that can be used throughout the step process. So passing the instance of the ticket would save one the trouble of looking up the authenticated ticket by the ticket ID in certain implementations.The text was updated successfully, but these errors were encountered: