Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel your action queue #5

Closed
jsha opened this issue Aug 4, 2014 · 5 comments
Closed

Cancel your action queue #5

jsha opened this issue Aug 4, 2014 · 5 comments

Comments

@jsha
Copy link
Owner

jsha commented Aug 4, 2014

No description provided.

@BooDoo
Copy link
Contributor

BooDoo commented Sep 19, 2014

Looking at this now, building on pending multi-select branch (54b5b7b)—seems trivial for minimum-viable behavior:

  • Add "Cancel Pending Actions" button to Actions page
  • Button sends simple POST, canceling all pending actions for the user

Small changes to actions (adding two functions, making getActions more flexible,) adding cancelled-manual status, and creating /cancel-actions.json POST route.

Gets slightly more complicated to provide "multi-select" on Actions page to selectively cancel pending actions; does that strike you as being worth including, or as overkill? The minimum-viable seems useful, if only as a Panic Button.

@jsha
Copy link
Owner Author

jsha commented Sep 19, 2014

I think multi-select to cancel specific actions is overkill like you say.

Thinking about this some more I'm not positive it's still necessary. At first launch I often had a big backlog of pending actions because suspended target users would clog up the queue indefinitely. Now that that's fixed I think most actions get executed too quickly for a panic button to be useful.

If you haven't put in too much work on this issue already, I might suggest picking an alternate to work on. For instance, I think #18 (paginate blocks) would be really valuable since we can't currently show all of a user's blocks if they have >5000. That would also let us pick a more reasonable threshold per page, say 500, so each page would load faster.

@BooDoo
Copy link
Contributor

BooDoo commented Sep 19, 2014

Just did a quick viability look over lunch; will shift focus to pagination building on master since it shouldn't overlap with multi-select branch's changes in any significant way.

@BooDoo
Copy link
Contributor

BooDoo commented Oct 13, 2014

Close and address in #96 instead?

@jsha
Copy link
Owner Author

jsha commented Oct 13, 2014

Yep, makes sense. Closing.

@jsha jsha closed this as completed Oct 13, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants