show_blocks pagination

[BooDoo]

Still need to resolve "Block All" behavior and use some less generic class names, but could you advise if I'm on the right path with how pagination behaves/is presented?

• Get total count of blocks in a BlockBatch within showBlocks()
• Fetch perPage (500) blocks at a time
• Offset blocks fetch based on "?page=" querystring
• Pass currentPage and pages[] to templates/show_blocks
• pagination.mustache made for inclusion in show-blocks
• CSS counters added to style.css for numbering pagination links
• pagination.js handles detecting current page and navigating to others
• Remove 'theres_more' flag

[jsha]

This is looking awesome! One small thing: Instead of setting handlers on the various page links, how about setting their href to the target URL? That way things like middle clicking work correctly.

Let me know when it's ready for a full review, and thanks.

[BooDoo]

Hadn't done literal hrefs because mu2 provides no access to current element value (raycmorgan/Mu#10) but since I'm leaning on jQuery for a few other things I'll update hrefs after load in there.

[jsha]

You might be able to get what you want out of Mustache with something like:

pages: _.range(1, Math.ceil(blocksCount / perPage) + 1).map(function(pageNum) {
return {
pageNum: pageNum,
isActive: pageNum === current
}
},

[BooDoo]

Ready for code review. "Block All" button hasn't been given special logic to block pages other than the currently visible one (client side JS not touched.)

Changes since first push:

• Rename classes for pagination template
• Hide pagination section if only one page is needed
• Rename classes used in pagination template

[jsha]

Excellent change, thanks!

[BooDoo]

So we can close #17 and #18 with this one?

[jsha]

Closed out #18. I think you had mentioned fixing #17 with this change, but I don't see the changes to the code to make that happen?

[BooDoo]

I misread #17's intent in my notes! This PR actually exacerbates it, not solves it.