adjust dt for external functions under R-K #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs to be improved: currently, this only works if codegen is used. |
|
The only solution I can think of, is to use the same variable names in both cases, when coder is used and when it is not. However, when coder is not used, we can pass pset.p as an argument and avoid saving params.mat. Jason, what do you think? In addition to solve the issue, that would clean the code in buildmodel (only saving params.mat would be different on the two versions), and it would make more clear to understand what is going on in odefun file when codegen is not used... |
|
I am merging this now, we will need to clean the code and use params.mat independently of coder/codegen options |
kupiqu
added a commit
that referenced
this pull request
Feb 25, 2015
adjust dt for external functions under R-K
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification is to keep the same precision for external functions, such as the Poisson input, dicated by the integration method. So if RK2 or RK4 is used instead of Euler, then actual dt of the external function is scaled down to 0.5dt.