Skip to content

Commit

Permalink
[[FIX]] Report error for offending token value
Browse files Browse the repository at this point in the history
When a "rest" operator is not followed by the identifier, report the
value of the unexpected token (not the "rest" operator itself).
  • Loading branch information
jugglinmike committed Oct 20, 2016
1 parent 2a31c94 commit 3b06d01
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 11 deletions.
2 changes: 1 addition & 1 deletion src/jshint.js
Expand Up @@ -1512,7 +1512,7 @@ var JSHINT = (function() {
}

if (!state.tokens.next.identifier) {
warning("E024", state.tokens.curr, "...");
warning("E024", state.tokens.curr, state.tokens.next.id);
return;
}

Expand Down
22 changes: 12 additions & 10 deletions tests/unit/parser.js
Expand Up @@ -7588,7 +7588,9 @@ exports.extraRestOperator = function (test) {
.addError(1, "Unexpected '...'.")
.addError(2, "Unexpected '...'.")
.addError(3, "Unexpected '...'.")
.addError(3, "Unexpected ')'.")
.addError(4, "Unexpected '...'.")
.addError(4, "Unexpected ')'.")
.addError(5, "Unexpected '...'.")
.addError(6, "Unexpected '...'.")
.addError(7, "Unexpected '...'.")
Expand Down Expand Up @@ -7624,16 +7626,16 @@ exports.restOperatorWithoutIdentifier = function (test) {
];

TestRun(test)
.addError(1, "Unexpected '...'.")
.addError(2, "Unexpected '...'.")
.addError(3, "Unexpected '...'.")
.addError(4, "Unexpected '...'.")
.addError(5, "Unexpected '...'.")
.addError(6, "Unexpected '...'.")
.addError(7, "Unexpected '...'.")
.addError(8, "Unexpected '...'.")
.addError(9, "Unexpected '...'.")
.addError(10, "Unexpected '...'.")
.addError(1, "Unexpected ']'.")
.addError(2, "Unexpected ']'.")
.addError(3, "Unexpected ')'.")
.addError(4, "Unexpected ')'.")
.addError(5, "Unexpected ']'.")
.addError(6, "Unexpected ']'.")
.addError(7, "Unexpected ')'.")
.addError(8, "Unexpected ')'.")
.addError(9, "Unexpected ']'.")
.addError(10, "Unexpected ']'.")
.test(code, { esnext: true });

test.done();
Expand Down

0 comments on commit 3b06d01

Please sign in to comment.